Re: [libvirt] [PATCH] qemu: Fix JSON migrate_set_downtime command

On Thu, Aug 19, 2010 at 10:36:55AM -0600, Eric Blake wrote: On 08/19/2010 10:33 AM, Eric Blake wrote: On 08/19/2010 08:47 AM, Jiri Denemark wrote: --- src/qemu/qemu_monitor_json.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git

Re: [libvirt] [PATCH] qemu: Fix JSON migrate_set_downtime command

On 08/20/2010 03:21 AM, Daniel P. Berrange wrote: Never mind. I was thinking too much of printf's %d. But with qemuMonitorJSONMakeCommand, d: is a double, and your division by 1000.0 does indeed create a value that passes just fine through varargs. I've never understood why printf() choose

Re: [libvirt] [PATCH] qemu: Fix JSON migrate_set_downtime command

src/qemu/qemu_monitor_json.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) ACK. Thanks, I pushed it now. Jirka -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] qemu: Fix JSON migrate_set_downtime command

--- src/qemu/qemu_monitor_json.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index e8609aa..8a586bc 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -1481,17 +1481,12 @@

Re: [libvirt] [PATCH] qemu: Fix JSON migrate_set_downtime command

On 08/19/2010 08:47 AM, Jiri Denemark wrote: --- src/qemu/qemu_monitor_json.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index e8609aa..8a586bc 100644 --- a/src/qemu/qemu_monitor_json.c +++

Re: [libvirt] [PATCH] qemu: Fix JSON migrate_set_downtime command

On 08/19/2010 10:33 AM, Eric Blake wrote: On 08/19/2010 08:47 AM, Jiri Denemark wrote: --- src/qemu/qemu_monitor_json.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index e8609aa..8a586bc 100644