Re: [libvirt] [PATCH] qemu: Fix crash hot plugging luks volume

2016-08-17 Thread Daniel P. Berrange
On Wed, Aug 17, 2016 at 10:19:40AM -0400, John Ferlan wrote: > > > On 08/17/2016 05:40 AM, Daniel P. Berrange wrote: > > On Tue, Aug 16, 2016 at 11:25:35AM -0400, John Ferlan wrote: > >> https://bugzilla.redhat.com/show_bug.cgi?id=1367259 > >> > >> Crash occurs because 'secrets' is being derefere

Re: [libvirt] [PATCH] qemu: Fix crash hot plugging luks volume

2016-08-17 Thread John Ferlan
On 08/17/2016 05:40 AM, Daniel P. Berrange wrote: > On Tue, Aug 16, 2016 at 11:25:35AM -0400, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1367259 >> >> Crash occurs because 'secrets' is being dereferenced in call: >> >> if (qemuDomainSecretSetup(conn, priv, secinfo,

Re: [libvirt] [PATCH] qemu: Fix crash hot plugging luks volume

2016-08-17 Thread Daniel P. Berrange
On Tue, Aug 16, 2016 at 11:25:35AM -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1367259 > > Crash occurs because 'secrets' is being dereferenced in call: > > if (qemuDomainSecretSetup(conn, priv, secinfo, disk->info.alias, > VIR

[libvirt] [PATCH] qemu: Fix crash hot plugging luks volume

2016-08-16 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1367259 Crash occurs because 'secrets' is being dereferenced in call: if (qemuDomainSecretSetup(conn, priv, secinfo, disk->info.alias, VIR_SECRET_USAGE_TYPE_VOLUME, NULL, &src->