Re: [libvirt] [PATCH] qemu: Fix failure path in disk hotplug

2012-09-21 Thread Jiri Denemark
On Thu, Sep 20, 2012 at 14:48:50 -0600, Eric Blake wrote: > On 09/20/2012 02:35 PM, Jiri Denemark wrote: > > Disk hotplug is a two phase action: qemuMonitorAddDrive followed by > > qemuMonitorAddDevice. When the first part succeeds but the second one > > fails, we need to rollback the drive additio

Re: [libvirt] [PATCH] qemu: Fix failure path in disk hotplug

2012-09-20 Thread Eric Blake
On 09/20/2012 02:35 PM, Jiri Denemark wrote: > Disk hotplug is a two phase action: qemuMonitorAddDrive followed by > qemuMonitorAddDevice. When the first part succeeds but the second one > fails, we need to rollback the drive addition. > --- > src/qemu/qemu_hotplug.c | 14 ++ > 1 file

[libvirt] [PATCH] qemu: Fix failure path in disk hotplug

2012-09-20 Thread Jiri Denemark
Disk hotplug is a two phase action: qemuMonitorAddDrive followed by qemuMonitorAddDevice. When the first part succeeds but the second one fails, we need to rollback the drive addition. --- src/qemu/qemu_hotplug.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/s