Re: [libvirt] [PATCH] qemu: Fix regression in snapshot-revert

2019-09-10 Thread Daniel Henrique Barboza
On 9/10/19 3:59 PM, Eric Blake wrote: On 9/9/19 5:17 PM, Daniel Henrique Barboza wrote: On 9/9/19 5:52 PM, Eric Blake wrote: Commit f10562799 introduced a regression: if reverting to a snapshot fails early (such as when we refuse to revert to an external snapshot), we lose track of the

Re: [libvirt] [PATCH] qemu: Fix regression in snapshot-revert

2019-09-10 Thread Eric Blake
On 9/9/19 5:17 PM, Daniel Henrique Barboza wrote: > > > On 9/9/19 5:52 PM, Eric Blake wrote: >> Commit f10562799 introduced a regression: if reverting to a snapshot >> fails early (such as when we refuse to revert to an external >> snapshot), we lose track of the domain's current snapshot. >> >>

Re: [libvirt] [PATCH] qemu: Fix regression in snapshot-revert

2019-09-09 Thread Daniel Henrique Barboza
On 9/9/19 5:52 PM, Eric Blake wrote: Commit f10562799 introduced a regression: if reverting to a snapshot fails early (such as when we refuse to revert to an external snapshot), we lose track of the domain's current snapshot. See: https://bugzilla.redhat.com/1738747 Signed-off-by: Eric Blake

[libvirt] [PATCH] qemu: Fix regression in snapshot-revert

2019-09-09 Thread Eric Blake
Commit f10562799 introduced a regression: if reverting to a snapshot fails early (such as when we refuse to revert to an external snapshot), we lose track of the domain's current snapshot. See: https://bugzilla.redhat.com/1738747 Signed-off-by: Eric Blake --- src/qemu/qemu_driver.c | 2 -- 1