Re: [libvirt] [PATCH] qemu: Fix specifying char devs for PPC

2014-05-21 Thread Ján Tomko
On 05/20/2014 07:25 AM, hong-hua@freescale.com wrote: Hi Cole, Thanks for the comments. Exactly there were already test cases for both pseries and ppce500 machines. For example, 1) qemuxml2argv-pseries-basic.args: '-chardev spapr-vty' for pseries. 2) qemuxml2argv-ppc-dtb.args:

Re: [libvirt] [PATCH] qemu: Fix specifying char devs for PPC

2014-05-21 Thread Li Zhang
On 2014年05月19日 15:41, hong-hua@freescale.com wrote: Hi Cole, This is a patch similar with your previous patch to fix for ARM. Do you have any comments on it? Cindy, Since you are the main contributor to QEMU driver on PPC, I'll also appreciate your comments. Hi Hong-hua, It looks good

Re: [libvirt] [PATCH] qemu: Fix specifying char devs for PPC

2014-05-21 Thread Li Zhang
On 2014年05月21日 14:00, Ján Tomko wrote: On 05/20/2014 07:25 AM, hong-hua@freescale.com wrote: Hi Cole, Thanks for the comments. Exactly there were already test cases for both pseries and ppce500 machines. For example, 1) qemuxml2argv-pseries-basic.args: '-chardev spapr-vty' for pseries.

Re: [libvirt] [PATCH] qemu: Fix specifying char devs for PPC

2014-05-20 Thread Cole Robinson
On 05/20/2014 01:25 AM, hong-hua@freescale.com wrote: Hi Cole, Thanks for the comments. Exactly there were already test cases for both pseries and ppce500 machines. For example, 1) qemuxml2argv-pseries-basic.args: '-chardev spapr-vty' for pseries. 2) qemuxml2argv-ppc-dtb.args:

Re: [libvirt] [PATCH] qemu: Fix specifying char devs for PPC

2014-05-20 Thread hong-hua....@freescale.com
Hi Cole, The fact is that we need maintain several patches to make libvirt to work with qemu-system-ppc on ppce500 platform. 1) enable QEMU_CAPS_PCI_MULTIBUS 2) use legacy -serial option The first one is not needed any more since libvirt v1.2.4. This patch is trying to fix the second one. The

Re: [libvirt] [PATCH] qemu: Fix specifying char devs for PPC

2014-05-19 Thread hong-hua....@freescale.com
Hi Cole, This is a patch similar with your previous patch to fix for ARM. Do you have any comments on it? Cindy, Since you are the main contributor to QEMU driver on PPC, I'll also appreciate your comments. Best Regards, Olivia -Original Message- From: Yin Olivia-R63875 Sent:

Re: [libvirt] [PATCH] qemu: Fix specifying char devs for PPC

2014-05-19 Thread Cole Robinson
On 05/19/2014 03:41 AM, hong-hua@freescale.com wrote: Hi Cole, This is a patch similar with your previous patch to fix for ARM. Do you have any comments on it? Cindy, Since you are the main contributor to QEMU driver on PPC, I'll also appreciate your comments. Best Regards,

Re: [libvirt] [PATCH] qemu: Fix specifying char devs for PPC

2014-05-19 Thread hong-hua....@freescale.com
Hi Cole, Thanks for the comments. Exactly there were already test cases for both pseries and ppce500 machines. For example, 1) qemuxml2argv-pseries-basic.args: '-chardev spapr-vty' for pseries. 2) qemuxml2argv-ppc-dtb.args: '-serial pty' for ppce500. Best Regards, Olivia

Re: [libvirt] [PATCH] qemu: Fix specifying char devs for PPC

2014-05-15 Thread hong-hua....@freescale.com
Ping. This is a patch similar with ARM platforms. http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=3a2beaee1d50dc968171c584ec2edcfdcb8fadde Right now on ppce500, chardev is not supported for the serial console. So it uses the the legacy -serial option. Best Regards, Olivia -Original

[libvirt] [PATCH] qemu: Fix specifying char devs for PPC

2014-05-14 Thread Olivia Yin
QEMU ppce500 board uses the old style -serial options. Other PPC boards don't give any way to explicitly wire in a -chardev except pseries which uses -device spapr-vty with -chardev. --- src/qemu/qemu_capabilities.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git