Re: [libvirt] [PATCH] qemu: fix potential memory leak

2019-09-19 Thread Daniel Henrique Barboza
On 9/19/19 5:00 AM, Xu Yandong wrote: function virTypedParamsAddString may return -1 but alloc params, so invoker should free it. Signed-off-by: Xu Yandong --- src/qemu/qemu_driver.c | 12 1 file changed, 12 insertions(+) diff --git a/src/qemu/qemu_driver.c

[libvirt] [PATCH] qemu: fix potential memory leak

2019-09-19 Thread Xu Yandong
function virTypedParamsAddString may return -1 but alloc params, so invoker should free it. Signed-off-by: Xu Yandong --- src/qemu/qemu_driver.c | 12 1 file changed, 12 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 1e041a8bac..62ce7270ca 100644

[libvirt] [PATCH] qemu: fix lastError memory leak

2013-12-02 Thread Wangyufei (James)
When an error occurred in qemuMonitorIO, it will be saved in mon-lastError, but the memory which mon-lastError.message, mon-lastError.str1, mon-lastError.str2 and mon-lastError.str3 will not be freed at last. The same bug happened in qemuAgentIO. So I add the following code to fix it.

Re: [libvirt] [PATCH] qemu: fix lastError memory leak

2013-12-02 Thread Eric Blake
On 12/02/2013 06:25 AM, Wangyufei (James) wrote: When an error occurred in qemuMonitorIO, it will be saved in mon-lastError, but the memory which mon-lastError.message, mon-lastError.str1, mon-lastError.str2 and mon-lastError.str3 will not be freed at last. The same bug happened in

[libvirt] [PATCH] qemu: Fix the memory leak

2013-02-20 Thread Osier Yang
Found by John Ferlan (coverity script) --- Assuming an ACK from John, and it's trivial, so pushed --- src/qemu/qemu_conf.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 8299b79..33fd67d 100644 --- a/src/qemu/qemu_conf.c

[libvirt] [PATCH] qemu: Fix one memory leak

2011-06-22 Thread Osier Yang
* src/qemu/qemu_domain.c: (qemuDomainAppendLog) Free message in cleanup. --- src/qemu/qemu_domain.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 5fe66ac..fab316f 100644 --- a/src/qemu/qemu_domain.c +++

Re: [libvirt] [PATCH] qemu: Fix one memory leak

2011-06-22 Thread Michal Privoznik
On 22.06.2011 12:20, Osier Yang wrote: * src/qemu/qemu_domain.c: (qemuDomainAppendLog) Free message in cleanup. --- src/qemu/qemu_domain.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 5fe66ac..fab316f

Re: [libvirt] [PATCH] qemu: Fix one memory leak

2011-06-22 Thread Osier Yang
于 2011年06月22日 18:04, Michal Privoznik 写道: On 22.06.2011 12:20, Osier Yang wrote: * src/qemu/qemu_domain.c: (qemuDomainAppendLog) Free message in cleanup. --- src/qemu/qemu_domain.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_domain.c

[libvirt] [PATCH] qemu: Fix one memory leak in qemu driver.c

2010-10-29 Thread Osier Yang
* src/qemu/qemu_driver.c (qemuDomainManagedSavePath) --- src/qemu/qemu_driver.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 89b4d11..976fb72 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@

Re: [libvirt] [PATCH] qemu: Fix one memory leak in qemu driver.c

2010-10-29 Thread Daniel P. Berrange
On Fri, Oct 29, 2010 at 04:53:11PM +0800, Osier Yang wrote: * src/qemu/qemu_driver.c (qemuDomainManagedSavePath) --- src/qemu/qemu_driver.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 89b4d11..976fb72 100644

Re: [libvirt] [PATCH] qemu: Fix a memory leak in qemudExtractTTYPath

2010-01-11 Thread Daniel P. Berrange
On Sat, Jan 09, 2010 at 09:26:11PM +0100, Matthias Bolte wrote: qemudWaitForMonitor calls qemudReadLogOutput with qemudFindCharDevicePTYs as callback. qemudFindCharDevicePTYs calls qemudExtractTTYPath to assign a string to chr-data.file.path. Afterwards qemudWaitForMonitor may call

Re: [libvirt] [PATCH] qemu: Fix a memory leak in qemudExtractTTYPath

2010-01-11 Thread Matthias Bolte
2010/1/11 Daniel P. Berrange berra...@redhat.com: On Sat, Jan 09, 2010 at 09:26:11PM +0100, Matthias Bolte wrote: qemudWaitForMonitor calls qemudReadLogOutput with qemudFindCharDevicePTYs as callback. qemudFindCharDevicePTYs calls qemudExtractTTYPath to assign a string to chr-data.file.path.