Re: [libvirt PATCH] qemu: honour fatal errors dealing with qemu slirp helper

2020-10-23 Thread Daniel Henrique Barboza
On 10/20/20 12:07 PM, Daniel P. Berrangé wrote: Currently all errors from qemuInterfacePrepareSlirp() are completely ignored by the callers. The intention is that missing qemu-slirp binary should cause the caller to fallback to the built-in slirp impl. Many of the possible errors though

[libvirt PATCH] qemu: honour fatal errors dealing with qemu slirp helper

2020-10-20 Thread Daniel P . Berrangé
Currently all errors from qemuInterfacePrepareSlirp() are completely ignored by the callers. The intention is that missing qemu-slirp binary should cause the caller to fallback to the built-in slirp impl. Many of the possible errors though should indeed be considered fatal. Signed-off-by: Daniel

Re: [libvirt] [PATCH] qemu: honour parseOpaque instead of refetching caps

2019-12-10 Thread Cole Robinson
On 12/10/19 7:43 AM, Daniel P. Berrangé wrote: > The use of the parseOpaque parameter was mistakenly removed in > > commit 4a4132b4625778cf80acb9c92d06351b44468ac3 > Author: Daniel P. Berrangé > Date: Tue Dec 3 10:49:49 2019 + > > conf: don't use passed in caps in post parse

[libvirt] [PATCH] qemu: honour parseOpaque instead of refetching caps

2019-12-10 Thread Daniel P . Berrangé
The use of the parseOpaque parameter was mistakenly removed in commit 4a4132b4625778cf80acb9c92d06351b44468ac3 Author: Daniel P. Berrangé Date: Tue Dec 3 10:49:49 2019 + conf: don't use passed in caps in post parse method causing the method to re-fetch qemuCaps that were

Re: [libvirt] [PATCH] qemu: Honour

2018-06-06 Thread Ruben Kerkhof
Hi Michal, Replying to an old thread: On Fri, Aug 4, 2017 at 9:55 AM, Michal Privoznik wrote: > I think this patch enables exactly that. The VM admins don't start the > domains by hand but probably have some SW that starts configured domains > whenever not running. E.g. if one domain crashes,

Re: [libvirt] [PATCH] qemu: Honour

2017-08-18 Thread Martin Kletzander
On Wed, Aug 16, 2017 at 03:55:19PM +0200, Michal Privoznik wrote: On 08/10/2017 04:02 PM, Martin Kletzander wrote: On Thu, Aug 03, 2017 at 09:36:27AM +0200, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1476866 For some reason, we completely ignore setting for domains.

Re: [libvirt] [PATCH] qemu: Honour

2017-08-16 Thread Michal Privoznik
On 08/10/2017 04:02 PM, Martin Kletzander wrote: > On Thu, Aug 03, 2017 at 09:36:27AM +0200, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1476866 >> >> For some reason, we completely ignore setting for >> domains. The implementation is simply not there. It never was. >>

Re: [libvirt] [PATCH] qemu: Honour

2017-08-10 Thread Martin Kletzander
On Thu, Aug 03, 2017 at 09:36:27AM +0200, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1476866 For some reason, we completely ignore setting for domains. The implementation is simply not there. It never was. However, things are slightly more complicated. QEMU sends us

Re: [libvirt] [PATCH] qemu: Honour

2017-08-04 Thread Michal Privoznik
On 08/03/2017 06:38 PM, Philipp Hahn wrote: > Hello, > > Am 03.08.2017 um 09:36 schrieb Michal Privoznik: >> https://bugzilla.redhat.com/show_bug.cgi?id=1476866 >> >> For some reason, we completely ignore setting for >> domains. The implementation is simply not there. It never was. >> However,

Re: [libvirt] [PATCH] qemu: Honour

2017-08-03 Thread Philipp Hahn
Hello, Am 03.08.2017 um 09:36 schrieb Michal Privoznik: > https://bugzilla.redhat.com/show_bug.cgi?id=1476866 > > For some reason, we completely ignore setting for > domains. The implementation is simply not there. It never was. > However, things are slightly more complicated. QEMU sends us two

[libvirt] [PATCH] qemu: Honour

2017-08-03 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=1476866 For some reason, we completely ignore setting for domains. The implementation is simply not there. It never was. However, things are slightly more complicated. QEMU sends us two RESET events on domain reboot. Fortunately, the event contains