Re: [libvirt] [PATCH] qemu: Improve some qemu.conf error reporting

2010-07-02 Thread Cole Robinson
On 07/01/2010 06:11 AM, Daniel P. Berrange wrote: > On Wed, Jun 30, 2010 at 04:38:36PM -0400, Cole Robinson wrote: >> Log some info if we can't find a config file. Make parse failures >> fatal, and actually raise an error message. >> >> Signed-off-by: Cole Robinson >> --- >> src/qemu/qemu_conf.c

Re: [libvirt] [PATCH] qemu: Improve some qemu.conf error reporting

2010-07-01 Thread Daniel P. Berrange
On Wed, Jun 30, 2010 at 04:38:36PM -0400, Cole Robinson wrote: > Log some info if we can't find a config file. Make parse failures > fatal, and actually raise an error message. > > Signed-off-by: Cole Robinson > --- > src/qemu/qemu_conf.c | 13 + > 1 files changed, 9 insertions(+),

Re: [libvirt] [PATCH] qemu: Improve some qemu.conf error reporting

2010-07-01 Thread Daniel P. Berrange
On Thu, Jul 01, 2010 at 11:51:17AM +1000, Justin Clift wrote: > On 07/01/2010 07:05 AM, Eric Blake wrote: > > >Hmm, this reminds me of my pending question of whether we should prefer > >__func__ (C99, and guaranteed by gnulib) or __FUNCTION__ (gcc-only, but > >easy to wrap on top of __func__): > >

Re: [libvirt] [PATCH] qemu: Improve some qemu.conf error reporting

2010-06-30 Thread Justin Clift
On 07/01/2010 07:05 AM, Eric Blake wrote: Hmm, this reminds me of my pending question of whether we should prefer __func__ (C99, and guaranteed by gnulib) or __FUNCTION__ (gcc-only, but easy to wrap on top of __func__): https://www.redhat.com/archives/libvir-list/2010-May/msg00319.html Ouch, d

Re: [libvirt] [PATCH] qemu: Improve some qemu.conf error reporting

2010-06-30 Thread Eric Blake
On 06/30/2010 02:38 PM, Cole Robinson wrote: > Log some info if we can't find a config file. Make parse failures > fatal, and actually raise an error message. > > Signed-off-by: Cole Robinson ACK. > #define CHECK_TYPE(name,typ) if (p && p->type != (typ)) { \ > qemuReport

[libvirt] [PATCH] qemu: Improve some qemu.conf error reporting

2010-06-30 Thread Cole Robinson
Log some info if we can't find a config file. Make parse failures fatal, and actually raise an error message. Signed-off-by: Cole Robinson --- src/qemu/qemu_conf.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c ind