Re: [libvirt] [PATCH] qemu: Introduce state_lock_timeout to qemu.conf

2018-09-12 Thread wang.yi59
> Yi Wang [2018-09-13, 10:39AM +0800]: > > diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c > > index 886e3fb..306772a 100644 > > --- a/src/qemu/qemu_domain.c > > +++ b/src/qemu/qemu_domain.c > > @@ -6652,9 +6652,6 @@ qemuDomainObjCanSetJob(qemuDomainObjPrivatePtr priv, > >

Re: [libvirt] [PATCH] qemu: Introduce state_lock_timeout to qemu.conf

2018-09-12 Thread Bjoern Walk
Yi Wang [2018-09-13, 10:39AM +0800]: > diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c > index 886e3fb..306772a 100644 > --- a/src/qemu/qemu_domain.c > +++ b/src/qemu/qemu_domain.c > @@ -6652,9 +6652,6 @@ qemuDomainObjCanSetJob(qemuDomainObjPrivatePtr priv, > priv->job.a

[libvirt] [PATCH] qemu: Introduce state_lock_timeout to qemu.conf

2018-09-12 Thread Yi Wang
When doing some job holding state lock for a long time, we may come across error: "Timed out during operation: cannot acquire state change lock" Well, sometimes it's not a problem and users want to continue to wait, and this patch allow users decide how long time they can wait the state lock. Si

Re: [libvirt] [PATCH] qemu: Introduce state_lock_timeout to qemu.conf

2018-08-27 Thread wang.yi59
Thanks for your review, Michal. I will send a v2 patch. > On 08/27/2018 08:04 AM, Yi Wang wrote: > > When doing some job holding state lock for a long time, > > we may come across error: > > "Timed out during operation: cannot acquire state change lock" > > Well, sometimes it's not a problem and u

Re: [libvirt] [PATCH] qemu: Introduce state_lock_timeout to qemu.conf

2018-08-27 Thread Michal Prívozník
On 08/27/2018 08:04 AM, Yi Wang wrote: > When doing some job holding state lock for a long time, > we may come across error: > "Timed out during operation: cannot acquire state change lock" > Well, sometimes it's not a problem and users wanner continue > to wait, and this patch allow users decide h

[libvirt] [PATCH] qemu: Introduce state_lock_timeout to qemu.conf

2018-08-26 Thread Yi Wang
When doing some job holding state lock for a long time, we may come across error: "Timed out during operation: cannot acquire state change lock" Well, sometimes it's not a problem and users wanner continue to wait, and this patch allow users decide how long time they can wait the state lock. Signe