Re: [libvirt] [PATCH] qemu: Prevent disk corruption on domain shutdown

2011-09-20 Thread Jiri Denemark
On Tue, Sep 20, 2011 at 11:31:06 +0800, Wen Congyang wrote: > At 09/15/2011 06:07 PM, Jiri Denemark Write: > > Ever since we introduced fake reboot, we call qemuProcessKill as a > > reaction to SHUTDOWN event. Unfortunately, qemu doesn't guarantee it > > flushed all internal buffers before sending

Re: [libvirt] [PATCH] qemu: Prevent disk corruption on domain shutdown

2011-09-19 Thread Wen Congyang
At 09/15/2011 06:07 PM, Jiri Denemark Write: > Ever since we introduced fake reboot, we call qemuProcessKill as a > reaction to SHUTDOWN event. Unfortunately, qemu doesn't guarantee it > flushed all internal buffers before sending SHUTDOWN, in which case > killing the process forcibly may result in

Re: [libvirt] [PATCH] qemu: Prevent disk corruption on domain shutdown

2011-09-16 Thread Jiri Denemark
On Fri, Sep 16, 2011 at 12:06:50 +0100, Daniel P. Berrange wrote: > On Thu, Sep 15, 2011 at 12:07:27PM +0200, Jiri Denemark wrote: > > Ever since we introduced fake reboot, we call qemuProcessKill as a > > reaction to SHUTDOWN event. Unfortunately, qemu doesn't guarantee it > > flushed all internal

Re: [libvirt] [PATCH] qemu: Prevent disk corruption on domain shutdown

2011-09-16 Thread Daniel P. Berrange
On Thu, Sep 15, 2011 at 12:07:27PM +0200, Jiri Denemark wrote: > Ever since we introduced fake reboot, we call qemuProcessKill as a > reaction to SHUTDOWN event. Unfortunately, qemu doesn't guarantee it > flushed all internal buffers before sending SHUTDOWN, in which case > killing the process forc

Re: [libvirt] [PATCH] qemu: Prevent disk corruption on domain shutdown

2011-09-15 Thread Jiri Denemark
On Thu, Sep 15, 2011 at 12:07:27 +0200, Jiri Denemark wrote: > Ever since we introduced fake reboot, we call qemuProcessKill as a > reaction to SHUTDOWN event. Unfortunately, qemu doesn't guarantee it > flushed all internal buffers before sending SHUTDOWN, in which case > killing the process forcib

[libvirt] [PATCH] qemu: Prevent disk corruption on domain shutdown

2011-09-15 Thread Jiri Denemark
Ever since we introduced fake reboot, we call qemuProcessKill as a reaction to SHUTDOWN event. Unfortunately, qemu doesn't guarantee it flushed all internal buffers before sending SHUTDOWN, in which case killing the process forcibly may result in (virtual) disk corruption. By sending just SIGTERM

Re: [libvirt] [PATCH] qemu: Prevent disk corruption on domain shutdown

2011-09-15 Thread Jiri Denemark
On Tue, Sep 13, 2011 at 17:00:38 -0600, Eric Blake wrote: > On 09/13/2011 10:20 AM, Jiri Denemark wrote: > > Ever since we introduced fake reboot, we call qemuProcessKill as a > > reaction to SHUTDOWN event. Unfortunately, qemu doesn't guarantee it > > flushed all internal buffers before sending SH

Re: [libvirt] [PATCH] qemu: Prevent disk corruption on domain shutdown

2011-09-14 Thread Daniel P. Berrange
On Tue, Sep 13, 2011 at 06:20:56PM +0200, Jiri Denemark wrote: > Ever since we introduced fake reboot, we call qemuProcessKill as a > reaction to SHUTDOWN event. Unfortunately, qemu doesn't guarantee it > flushed all internal buffers before sending SHUTDOWN, in which case > killing the process forc

Re: [libvirt] [PATCH] qemu: Prevent disk corruption on domain shutdown

2011-09-13 Thread Eric Blake
On 09/13/2011 10:20 AM, Jiri Denemark wrote: Ever since we introduced fake reboot, we call qemuProcessKill as a reaction to SHUTDOWN event. Unfortunately, qemu doesn't guarantee it flushed all internal buffers before sending SHUTDOWN, in which case killing the process forcibly may result in (virt

[libvirt] [PATCH] qemu: Prevent disk corruption on domain shutdown

2011-09-13 Thread Jiri Denemark
Ever since we introduced fake reboot, we call qemuProcessKill as a reaction to SHUTDOWN event. Unfortunately, qemu doesn't guarantee it flushed all internal buffers before sending SHUTDOWN, in which case killing the process forcibly may result in (virtual) disk corruption. By sending SIGQUIT inste