Re: [libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-12 Thread Osier Yang
于 2011年01月11日 23:33, Eric Blake 写道: On 01/11/2011 04:29 AM, Daniel P. Berrange wrote: On Tue, Jan 11, 2011 at 03:43:07PM +0800, Osier Yang wrote: If the emulator doesn't support SDL graphic, we should reject the use of SDL graphic xml with error messages, but not ignore it silently. *

Re: [libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-11 Thread Daniel P. Berrange
On Tue, Jan 11, 2011 at 03:43:07PM +0800, Osier Yang wrote: If the emulator doesn't support SDL graphic, we should reject the use of SDL graphic xml with error messages, but not ignore it silently. * src/qemu/qemu_command.c NACK. Most previous versions of QEMU don't have any explicit -sdl

Re: [libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-11 Thread Osier Yang
于 2011年01月11日 19:29, Daniel P. Berrange 写道: On Tue, Jan 11, 2011 at 03:43:07PM +0800, Osier Yang wrote: If the emulator doesn't support SDL graphic, we should reject the use of SDL graphic xml with error messages, but not ignore it silently. * src/qemu/qemu_command.c NACK. Most previous

Re: [libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-11 Thread Richard W.M. Jones
On Tue, Jan 11, 2011 at 09:21:26PM +0800, Osier Yang wrote: So, it means the newer qemu-kvm (of RHEL) doesn't support sdl anymore. Didn't send the patch to Red Hat internal list, as the patch won't conflict with upstream. IMHO it's not reasonable that we have sdl xml in domain config, but

Re: [libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-11 Thread Justin Clift
On 12/01/2011, at 12:39 AM, Richard W.M. Jones wrote: On Tue, Jan 11, 2011 at 09:21:26PM +0800, Osier Yang wrote: So, it means the newer qemu-kvm (of RHEL) doesn't support sdl anymore. Didn't send the patch to Red Hat internal list, as the patch won't conflict with upstream. IMHO it's not

Re: [libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-11 Thread Osier Yang
于 2011年01月11日 22:01, Justin Clift 写道: On 12/01/2011, at 12:39 AM, Richard W.M. Jones wrote: On Tue, Jan 11, 2011 at 09:21:26PM +0800, Osier Yang wrote: So, it means the newer qemu-kvm (of RHEL) doesn't support sdl anymore. Didn't send the patch to Red Hat internal list, as the patch won't

Re: [libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-11 Thread Osier Yang
于 2011年01月11日 21:39, Richard W.M. Jones 写道: On Tue, Jan 11, 2011 at 09:21:26PM +0800, Osier Yang wrote: So, it means the newer qemu-kvm (of RHEL) doesn't support sdl anymore. Didn't send the patch to Red Hat internal list, as the patch won't conflict with upstream. IMHO it's not reasonable

Re: [libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-11 Thread Daniel P. Berrange
On Wed, Jan 12, 2011 at 01:01:25AM +1100, Justin Clift wrote: On 12/01/2011, at 12:39 AM, Richard W.M. Jones wrote: On Tue, Jan 11, 2011 at 09:21:26PM +0800, Osier Yang wrote: So, it means the newer qemu-kvm (of RHEL) doesn't support sdl anymore. Didn't send the patch to Red Hat internal

Re: [libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-11 Thread Richard W.M. Jones
On Tue, Jan 11, 2011 at 10:03:42PM +0800, Osier Yang wrote: 于 2011年01月11日 21:39, Richard W.M. Jones 写道: On Tue, Jan 11, 2011 at 09:21:26PM +0800, Osier Yang wrote: So, it means the newer qemu-kvm (of RHEL) doesn't support sdl anymore. Didn't send the patch to Red Hat internal list, as the

Re: [libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-11 Thread Eric Blake
On 01/11/2011 04:29 AM, Daniel P. Berrange wrote: On Tue, Jan 11, 2011 at 03:43:07PM +0800, Osier Yang wrote: If the emulator doesn't support SDL graphic, we should reject the use of SDL graphic xml with error messages, but not ignore it silently. * src/qemu/qemu_command.c NACK. Most

Re: [libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-11 Thread Osier Yang
于 2011年01月11日 22:25, Richard W.M. Jones 写道: On Tue, Jan 11, 2011 at 10:03:42PM +0800, Osier Yang wrote: 于 2011年01月11日 21:39, Richard W.M. Jones 写道: On Tue, Jan 11, 2011 at 09:21:26PM +0800, Osier Yang wrote: So, it means the newer qemu-kvm (of RHEL) doesn't support sdl anymore. Didn't send

Re: [libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-11 Thread Osier Yang
于 2011年01月11日 23:33, Eric Blake 写道: On 01/11/2011 04:29 AM, Daniel P. Berrange wrote: On Tue, Jan 11, 2011 at 03:43:07PM +0800, Osier Yang wrote: If the emulator doesn't support SDL graphic, we should reject the use of SDL graphic xml with error messages, but not ignore it silently. *

[libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-10 Thread Osier Yang
If the emulator doesn't support SDL graphic, we should reject the use of SDL graphic xml with error messages, but not ignore it silently. * src/qemu/qemu_command.c --- src/qemu/qemu_command.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git