Re: [libvirt] [PATCH] qemu: Remove double unlock for domains

2015-08-03 Thread John Ferlan
On 08/03/2015 10:04 AM, Martin Kletzander wrote: On Mon, Aug 03, 2015 at 04:00:32PM +0200, Martin Kletzander wrote: On Mon, Aug 03, 2015 at 09:21:51AM -0400, John Ferlan wrote: On 07/15/2015 03:17 AM, Martin Kletzander wrote: The virDomainObjListRemove() function unlocks a domain that it's

Re: [libvirt] [PATCH] qemu: Remove double unlock for domains

2015-08-03 Thread Martin Kletzander
On Wed, Jul 15, 2015 at 09:17:46AM +0200, Martin Kletzander wrote: The virDomainObjListRemove() function unlocks a domain that it's given due to legacy code. And because of that code, which should be refactored, that last virObjectUnlock() cannot be just removed. So instead, lock it right back

Re: [libvirt] [PATCH] qemu: Remove double unlock for domains

2015-08-03 Thread John Ferlan
On 07/15/2015 03:17 AM, Martin Kletzander wrote: The virDomainObjListRemove() function unlocks a domain that it's given due to legacy code. And because of that code, which should be refactored, that last virObjectUnlock() cannot be just removed. So instead, lock it right back for qemu for

Re: [libvirt] [PATCH] qemu: Remove double unlock for domains

2015-08-03 Thread Martin Kletzander
On Mon, Aug 03, 2015 at 04:00:32PM +0200, Martin Kletzander wrote: On Mon, Aug 03, 2015 at 09:21:51AM -0400, John Ferlan wrote: On 07/15/2015 03:17 AM, Martin Kletzander wrote: The virDomainObjListRemove() function unlocks a domain that it's given due to legacy code. And because of that

Re: [libvirt] [PATCH] qemu: Remove double unlock for domains

2015-08-03 Thread Martin Kletzander
On Mon, Aug 03, 2015 at 09:21:51AM -0400, John Ferlan wrote: On 07/15/2015 03:17 AM, Martin Kletzander wrote: The virDomainObjListRemove() function unlocks a domain that it's given due to legacy code. And because of that code, which should be refactored, that last virObjectUnlock() cannot be

[libvirt] [PATCH] qemu: Remove double unlock for domains

2015-07-15 Thread Martin Kletzander
The virDomainObjListRemove() function unlocks a domain that it's given due to legacy code. And because of that code, which should be refactored, that last virObjectUnlock() cannot be just removed. So instead, lock it right back for qemu for now. All calls to qemuDomainRemoveInactive() are