Re: [libvirt] [PATCH] qemu: Report errors from iohelper

2012-10-29 Thread Michal Privoznik
On 25.10.2012 23:56, Eric Blake wrote: On 10/24/2012 09:49 AM, Michal Privoznik wrote: Currently, we use iohelper when saving/restoring a domain. However, if there's some kind of error (like I/O) it is not propagated to libvirt. Since it is not qemu who is doing the actual write() it will not

Re: [libvirt] [PATCH] qemu: Report errors from iohelper

2012-10-29 Thread Eric Blake
On 10/29/2012 10:08 AM, Michal Privoznik wrote: On 25.10.2012 23:56, Eric Blake wrote: On 10/24/2012 09:49 AM, Michal Privoznik wrote: Currently, we use iohelper when saving/restoring a domain. However, if there's some kind of error (like I/O) it is not propagated to libvirt. Since it is not

Re: [libvirt] [PATCH] qemu: Report errors from iohelper

2012-10-25 Thread Eric Blake
On 10/24/2012 09:49 AM, Michal Privoznik wrote: Currently, we use iohelper when saving/restoring a domain. However, if there's some kind of error (like I/O) it is not propagated to libvirt. Since it is not qemu who is doing the actual write() it will not get error. The iohelper does.

[libvirt] [PATCH] qemu: Report errors from iohelper

2012-10-24 Thread Michal Privoznik
Currently, we use iohelper when saving/restoring a domain. However, if there's some kind of error (like I/O) it is not propagated to libvirt. Since it is not qemu who is doing the actual write() it will not get error. The iohelper does. Therefore we should check for iohelper errors as it makes

Re: [libvirt] [PATCH] qemu: Report errors from iohelper

2012-10-24 Thread Michal Privoznik
On 24.10.2012 17:49, Michal Privoznik wrote: Currently, we use iohelper when saving/restoring a domain. However, if there's some kind of error (like I/O) it is not propagated to libvirt. Since it is not qemu who is doing the actual write() it will not get error. The iohelper does. Therefore

[libvirt] [PATCH] qemu: Report errors from iohelper

2012-10-23 Thread Michal Privoznik
Currently, we use iohelper when saving/restoring a domain. However, if there's some kind of error (like I/O) it is not propagated to libvirt. Since it is not qemu who is doing the actual write() it will not get error. The iohelper does. Therefore we should check for iohelper errors as it makes

Re: [libvirt] [PATCH] qemu: Report errors from iohelper

2012-10-23 Thread Eric Blake
On 10/23/2012 03:39 AM, Michal Privoznik wrote: Currently, we use iohelper when saving/restoring a domain. However, if there's some kind of error (like I/O) it is not propagated to libvirt. Since it is not qemu who is doing the actual write() it will not get error. The iohelper does.

Re: [libvirt] [PATCH] qemu: Report errors from iohelper

2012-10-23 Thread Michal Privoznik
On 23.10.2012 16:51, Eric Blake wrote: On 10/23/2012 03:39 AM, Michal Privoznik wrote: Currently, we use iohelper when saving/restoring a domain. However, if there's some kind of error (like I/O) it is not propagated to libvirt. Since it is not qemu who is doing the actual write() it will not