Re: [libvirt] [PATCH] qemu: Substitute VIR_ERR_NO_SUPPORT with VIR_ERR_OPERATION_INVALID

2011-08-23 Thread Osier Yang
于 2011年08月22日 21:54, Eric Blake 写道: On 08/22/2011 08:12 AM, Osier Yang wrote: * src/qemu/qemu_monitor_text.c: Error like this function is not supported by the connection driver is confused obviously. --- src/qemu/qemu_monitor_text.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)

[libvirt] [PATCH] qemu: Substitute VIR_ERR_NO_SUPPORT with VIR_ERR_OPERATION_INVALID

2011-08-22 Thread Osier Yang
* src/qemu/qemu_monitor_text.c: Error like this function is not supported by the connection driver is confused obviously. --- src/qemu/qemu_monitor_text.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_monitor_text.c b/src/qemu/qemu_monitor_text.c

Re: [libvirt] [PATCH] qemu: Substitute VIR_ERR_NO_SUPPORT with VIR_ERR_OPERATION_INVALID

2011-08-22 Thread Eric Blake
On 08/22/2011 08:12 AM, Osier Yang wrote: * src/qemu/qemu_monitor_text.c: Error like this function is not supported by the connection driver is confused obviously. --- src/qemu/qemu_monitor_text.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) ACK. You are correct that

Re: [libvirt] [PATCH] qemu: Substitute VIR_ERR_NO_SUPPORT with VIR_ERR_OPERATION_INVALID

2011-08-22 Thread Osier Yang
于 2011年08月22日 21:54, Eric Blake 写道: On 08/22/2011 08:12 AM, Osier Yang wrote: * src/qemu/qemu_monitor_text.c: Error like this function is not supported by the connection driver is confused obviously. --- src/qemu/qemu_monitor_text.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)

Re: [libvirt] [PATCH] qemu: Substitute VIR_ERR_NO_SUPPORT with VIR_ERR_OPERATION_INVALID

2011-08-22 Thread Eric Blake
On 08/22/2011 08:50 AM, Osier Yang wrote: But seems it's fine for funcs like below to use that? int virSecurityManagerSetAllLabel(virSecurityManagerPtr mgr, virDomainObjPtr vm, const char *stdin_path) { if (mgr-drv-domainSetSecurityAllLabel) return mgr-drv-domainSetSecurityAllLabel(mgr, vm,