Re: [libvirt] [PATCH] qemu: Support chardevs with ARM virt machines

2017-06-26 Thread Cole Robinson
On 06/26/2017 11:19 AM, Andrew Jones wrote: > On Mon, Jun 26, 2017 at 10:10:55AM -0400, Cole Robinson wrote: >> On 06/24/2017 10:07 PM, Andrea Bolognani wrote: >>> On Sat, 2017-06-24 at 16:07 +0200, Christoffer Dall wrote: At this point I'm a little confused about how to proceed here. Would >

Re: [libvirt] [PATCH] qemu: Support chardevs with ARM virt machines

2017-06-26 Thread Andrew Jones
On Mon, Jun 26, 2017 at 10:10:55AM -0400, Cole Robinson wrote: > On 06/24/2017 10:07 PM, Andrea Bolognani wrote: > > On Sat, 2017-06-24 at 16:07 +0200, Christoffer Dall wrote: > >> At this point I'm a little confused about how to proceed here. Would > >> you like further evidence of an environment

Re: [libvirt] [PATCH] qemu: Support chardevs with ARM virt machines

2017-06-26 Thread Cole Robinson
On 06/24/2017 10:07 PM, Andrea Bolognani wrote: > On Sat, 2017-06-24 at 16:07 +0200, Christoffer Dall wrote: >>> The way I see it, the bug is about libvirt being unable to >>> launch guests which use the feature, and with >>> that in mind your patch is correct but doesn't solve the >>> issue, beca

Re: [libvirt] [PATCH] qemu: Support chardevs with ARM virt machines

2017-06-26 Thread Andrea Bolognani
On Mon, 2017-06-26 at 15:06 +0200, Andrew Jones wrote: > > Cool,  I'll have a look as well and will document my complete > > environment, then hopefully we can diff with yours and see where this > > ISA thing shows up. >  > It's likely a pci-serial vs. isa-serial device getting created. Something >

Re: [libvirt] [PATCH] qemu: Support chardevs with ARM virt machines

2017-06-26 Thread Andrew Jones
On Sun, 2017-06-25 at 13:46 +0200, Christoffer Dall wrote: >>On Sun, Jun 25, 2017 at 4:07 AM, Andrea Bolognani wrote: >> On Sat, 2017-06-24 at 16:07 +0200, Christoffer Dall wrote: >>> > The way I see it, the bug is about libvirt being unable to >>> > launch guests which use the feature, and with

Re: [libvirt] [PATCH] qemu: Support chardevs with ARM virt machines

2017-06-25 Thread Christoffer Dall
On Sun, Jun 25, 2017 at 4:07 AM, Andrea Bolognani wrote: > On Sat, 2017-06-24 at 16:07 +0200, Christoffer Dall wrote: >> > The way I see it, the bug is about libvirt being unable to >> > launch guests which use the feature, and with >> > that in mind your patch is correct but doesn't solve the >>

Re: [libvirt] [PATCH] qemu: Support chardevs with ARM virt machines

2017-06-25 Thread Andrea Bolognani
On Sat, 2017-06-24 at 16:07 +0200, Christoffer Dall wrote: > > The way I see it, the bug is about libvirt being unable to > > launch guests which use the feature, and with > > that in mind your patch is correct but doesn't solve the > > issue, because even thought that specific error is gone you >

Re: [libvirt] [PATCH] qemu: Support chardevs with ARM virt machines

2017-06-25 Thread Andrea Bolognani
On Fri, 2017-06-23 at 18:32 +0200, Christoffer Dall wrote: > > You mention in [1] that applying this patch and using a > > recent QEMU fixes the problem for you, however I can't > > say the same: I still get > >  > >   -device isa-serial,chardev=charserial0,id=serial0: > >   No 'ISA' bus found for

Re: [libvirt] [PATCH] qemu: Support chardevs with ARM virt machines

2017-06-24 Thread Christoffer Dall
On Sat, Jun 24, 2017 at 3:37 PM, Andrea Bolognani wrote: > On Fri, 2017-06-23 at 18:32 +0200, Christoffer Dall wrote: >> > You mention in [1] that applying this patch and using a >> > recent QEMU fixes the problem for you, however I can't >> > say the same: I still get >> > >> > -device isa-seri

Re: [libvirt] [PATCH] qemu: Support chardevs with ARM virt machines

2017-06-23 Thread Christoffer Dall
On Thu, Jun 22, 2017 at 8:30 AM, Andrea Bolognani wrote: > On Wed, 2017-06-07 at 23:13 +0200, Christoffer Dall wrote: >> The function to check if -chardev is supported by QEMU was written a >> long time ago, where adding chardevs did not make sense on the fixed ARM >> platforms. Since then, we no

Re: [libvirt] [PATCH] qemu: Support chardevs with ARM virt machines

2017-06-21 Thread Andrea Bolognani
On Wed, 2017-06-07 at 23:13 +0200, Christoffer Dall wrote: > The function to check if -chardev is supported by QEMU was written a > long time ago, where adding chardevs did not make sense on the fixed ARM > platforms.  Since then, we now have a general purpose virt platform, > which should support

Re: [libvirt] [PATCH] qemu: Support chardevs with ARM virt machines

2017-06-21 Thread Christoffer Dall
On Wed, Jun 7, 2017 at 11:13 PM, Christoffer Dall wrote: > The function to check if -chardev is supported by QEMU was written a > long time ago, where adding chardevs did not make sense on the fixed ARM > platforms. Since then, we now have a general purpose virt platform, > which should support p

[libvirt] [PATCH] qemu: Support chardevs with ARM virt machines

2017-06-07 Thread Christoffer Dall
The function to check if -chardev is supported by QEMU was written a long time ago, where adding chardevs did not make sense on the fixed ARM platforms. Since then, we now have a general purpose virt platform, which should support plugging in any device over PCIe which is supported in a similar fa