Re: [libvirt] [PATCH] qemu: allow blkstat/blkinfo calls during migration

2011-05-16 Thread Daniel P. Berrange
On Fri, May 13, 2011 at 05:05:14PM -0600, Eric Blake wrote: On 05/13/2011 04:11 AM, Federico Simoncelli wrote: Originally most of libvirt domain-specific calls were blocking during a migration. A new mechanism to allow specific calls (blkstat/blkinfo) to be executed in such condition has

Re: [libvirt] [PATCH] qemu: allow blkstat/blkinfo calls during migration

2011-05-16 Thread Eric Blake
On 05/13/2011 04:11 AM, Federico Simoncelli wrote: Originally most of libvirt domain-specific calls were blocking during a migration. A new mechanism to allow specific calls (blkstat/blkinfo) to be executed in such condition has been implemented. In the long term it'd be desirable to get a

Re: [libvirt] [PATCH] qemu: allow blkstat/blkinfo calls during migration

2011-05-13 Thread Federico Simoncelli
- Original Message - From: Eric Blake ebl...@redhat.com To: Federico Simoncelli fsimo...@redhat.com Cc: libvir-list@redhat.com Sent: Friday, May 13, 2011 1:38:45 AM Subject: Re: [PATCH] qemu: allow blkstat/blkinfo calls during migration On 05/11/2011 07:26 AM, Federico Simoncelli

[libvirt] [PATCH] qemu: allow blkstat/blkinfo calls during migration

2011-05-13 Thread Federico Simoncelli
Originally most of libvirt domain-specific calls were blocking during a migration. A new mechanism to allow specific calls (blkstat/blkinfo) to be executed in such condition has been implemented. In the long term it'd be desirable to get a more general solution to mark further APIs as migration

Re: [libvirt] [PATCH] qemu: allow blkstat/blkinfo calls during migration

2011-05-13 Thread Eric Blake
On 05/13/2011 04:11 AM, Federico Simoncelli wrote: Originally most of libvirt domain-specific calls were blocking during a migration. A new mechanism to allow specific calls (blkstat/blkinfo) to be executed in such condition has been implemented. In the long term it'd be desirable to get a

Re: [libvirt] [PATCH] qemu: allow blkstat/blkinfo calls during migration

2011-05-12 Thread Eric Blake
On 05/11/2011 07:26 AM, Federico Simoncelli wrote: Originally most of libvirt domain-specific calls were blocking during a migration. A new mechanism to allow specific calls (blkstat/blkinfo) to be executed in such condition has been implemented. In the long term it'd be desirable to get a

Re: [libvirt] [PATCH] qemu: allow blkstat/blkinfo calls during migration

2011-05-11 Thread Federico Simoncelli
Hi Eric, thank you for the quick and detailed patch review! I think I fixed all the problems that you described but if you find anything that I missed or anything new I'll be happy to accept the help you offered :) You can update my email address in AUTHORS to the redhat one. commit

[libvirt] [PATCH] qemu: allow blkstat/blkinfo calls during migration

2011-05-11 Thread Federico Simoncelli
Originally most of libvirt domain-specific calls were blocking during a migration. A new mechanism to allow specific calls (blkstat/blkinfo) to be executed in such condition has been implemented. In the long term it'd be desirable to get a more general solution to mark further APIs as migration

[libvirt] [PATCH] qemu: allow blkstat/blkinfo calls during migration

2011-05-10 Thread Federico Simoncelli
References: - https://www.redhat.com/archives/libvir-list/2011-May/msg00210.html - https://www.redhat.com/archives/libvir-list/2011-May/msg00287.html --- src/qemu/qemu_domain.c|6 +++ src/qemu/qemu_domain.h|7 src/qemu/qemu_driver.c| 86

Re: [libvirt] [PATCH] qemu: allow blkstat/blkinfo calls during migration

2011-05-10 Thread Eric Blake
On 05/10/2011 09:57 AM, Federico Simoncelli wrote: References: - https://www.redhat.com/archives/libvir-list/2011-May/msg00210.html - https://www.redhat.com/archives/libvir-list/2011-May/msg00287.html Can you also provide a summary of these messages, as well as a summary of your code