Re: [libvirt] [PATCH] qemu: avoid double shutdown

2011-02-03 Thread Eric Blake
On 02/03/2011 06:14 AM, Jiri Denemark wrote: > On Wed, Feb 02, 2011 at 11:37:37 -0700, Eric Blake wrote: >> * src/qemu/qemu_driver.c (qemudShutdownVMDaemon): Check that vm is >> still active. >> Reported by Wen Congyang as follows: >> >> --- >> +++ b/src/qemu/qemu_driver.c >> @@ -2991,6 +2991,11 @@

Re: [libvirt] [PATCH] qemu: avoid double shutdown

2011-02-03 Thread Jiri Denemark
On Wed, Feb 02, 2011 at 11:37:37 -0700, Eric Blake wrote: > * src/qemu/qemu_driver.c (qemudShutdownVMDaemon): Check that vm is > still active. > Reported by Wen Congyang as follows: > > --- > > I was able to reproduce a segfault due to double shutdown, as > well as testing that this patch avoids

[libvirt] [PATCH] qemu: avoid double shutdown

2011-02-02 Thread Eric Blake
* src/qemu/qemu_driver.c (qemudShutdownVMDaemon): Check that vm is still active. Reported by Wen Congyang as follows: Steps to reproduce this bug: 1. use gdb to debug libvirtd, and set breakpoint in the function qemuConnectMonitor() 2. start a vm, and the libvirtd will be stopped in qemuConnec