Re: [libvirt] [PATCH] qemu: blockcopy: Initialize correct source structure

2014-07-15 Thread Peter Krempa
On 07/15/14 15:24, Eric Blake wrote: > On 07/15/2014 02:35 AM, Peter Krempa wrote: >> 4cc1f1a01fb338de939ba88eb933931687b22336 introduced a crash when doing a >> block copy as virStorageSourceInitChainElement was called on >> "disk->mirror" that is still NULL at that point instead of "mirror" >> wh

Re: [libvirt] [PATCH] qemu: blockcopy: Initialize correct source structure

2014-07-15 Thread Eric Blake
On 07/15/2014 02:35 AM, Peter Krempa wrote: > 4cc1f1a01fb338de939ba88eb933931687b22336 introduced a crash when doing a > block copy as virStorageSourceInitChainElement was called on > "disk->mirror" that is still NULL at that point instead of "mirror" > which temporarily holds the mirror source str

[libvirt] [PATCH] qemu: blockcopy: Initialize correct source structure

2014-07-15 Thread Peter Krempa
4cc1f1a01fb338de939ba88eb933931687b22336 introduced a crash when doing a block copy as virStorageSourceInitChainElement was called on "disk->mirror" that is still NULL at that point instead of "mirror" which temporarily holds the mirror source struct until it's fully initialized. This resulted into