Re: [libvirt] [PATCH] qemu: configurable VNC port boundaries for domains

2012-05-28 Thread Dan Kenigsberg
On Wed, May 23, 2012 at 10:31:12AM +0100, Daniel P. Berrange wrote: On Tue, May 22, 2012 at 11:00:16AM -0400, Dave Allan wrote: On Tue, May 22, 2012 at 04:10:03PM +0200, Martin Kletzander wrote: The defines QEMU_VNC_PORT_MIN and QEMU_VNC_PORT_MAX were used to find free port when starting

Re: [libvirt] [PATCH] qemu: configurable VNC port boundaries for domains

2012-05-28 Thread Daniel P. Berrange
On Mon, May 28, 2012 at 03:18:33PM +0300, Dan Kenigsberg wrote: On Wed, May 23, 2012 at 10:31:12AM +0100, Daniel P. Berrange wrote: On Tue, May 22, 2012 at 11:00:16AM -0400, Dave Allan wrote: On Tue, May 22, 2012 at 04:10:03PM +0200, Martin Kletzander wrote: The defines QEMU_VNC_PORT_MIN

Re: [libvirt] [PATCH] qemu: configurable VNC port boundaries for domains

2012-05-28 Thread Daniel P. Berrange
On Tue, May 22, 2012 at 04:10:03PM +0200, Martin Kletzander wrote: The defines QEMU_VNC_PORT_MIN and QEMU_VNC_PORT_MAX were used to find free port when starting domains. As this was hardcoded to the same ports as default VNC servers, there were races with these other programs. This patch

Re: [libvirt] [PATCH] qemu: configurable VNC port boundaries for domains

2012-05-23 Thread Martin Kletzander
On 05/22/2012 07:22 PM, Dave Allan wrote: On Tue, May 22, 2012 at 09:09:55AM -0600, Eric Blake wrote: On 05/22/2012 09:00 AM, Dave Allan wrote: On Tue, May 22, 2012 at 04:10:03PM +0200, Martin Kletzander wrote: The defines QEMU_VNC_PORT_MIN and QEMU_VNC_PORT_MAX were used to find free port

Re: [libvirt] [PATCH] qemu: configurable VNC port boundaries for domains

2012-05-23 Thread Daniel P. Berrange
On Tue, May 22, 2012 at 01:22:16PM -0400, Dave Allan wrote: On Tue, May 22, 2012 at 09:09:55AM -0600, Eric Blake wrote: On 05/22/2012 09:00 AM, Dave Allan wrote: On Tue, May 22, 2012 at 04:10:03PM +0200, Martin Kletzander wrote: The defines QEMU_VNC_PORT_MIN and QEMU_VNC_PORT_MAX were

Re: [libvirt] [PATCH] qemu: configurable VNC port boundaries for domains

2012-05-23 Thread Daniel P. Berrange
On Tue, May 22, 2012 at 11:00:16AM -0400, Dave Allan wrote: On Tue, May 22, 2012 at 04:10:03PM +0200, Martin Kletzander wrote: The defines QEMU_VNC_PORT_MIN and QEMU_VNC_PORT_MAX were used to find free port when starting domains. As this was hardcoded to the same ports as default VNC

[libvirt] [PATCH] qemu: configurable VNC port boundaries for domains

2012-05-22 Thread Martin Kletzander
The defines QEMU_VNC_PORT_MIN and QEMU_VNC_PORT_MAX were used to find free port when starting domains. As this was hardcoded to the same ports as default VNC servers, there were races with these other programs. This patch includes the possibility to change the default starting port as well as the

Re: [libvirt] [PATCH] qemu: configurable VNC port boundaries for domains

2012-05-22 Thread Dave Allan
On Tue, May 22, 2012 at 04:10:03PM +0200, Martin Kletzander wrote: The defines QEMU_VNC_PORT_MIN and QEMU_VNC_PORT_MAX were used to find free port when starting domains. As this was hardcoded to the same ports as default VNC servers, there were races with these other programs. This patch

Re: [libvirt] [PATCH] qemu: configurable VNC port boundaries for domains

2012-05-22 Thread Eric Blake
On 05/22/2012 09:00 AM, Dave Allan wrote: On Tue, May 22, 2012 at 04:10:03PM +0200, Martin Kletzander wrote: The defines QEMU_VNC_PORT_MIN and QEMU_VNC_PORT_MAX were used to find free port when starting domains. As this was hardcoded to the same ports as default VNC servers, there were races

Re: [libvirt] [PATCH] qemu: configurable VNC port boundaries for domains

2012-05-22 Thread Dave Allan
On Tue, May 22, 2012 at 09:09:55AM -0600, Eric Blake wrote: On 05/22/2012 09:00 AM, Dave Allan wrote: On Tue, May 22, 2012 at 04:10:03PM +0200, Martin Kletzander wrote: The defines QEMU_VNC_PORT_MIN and QEMU_VNC_PORT_MAX were used to find free port when starting domains. As this was