Re: [libvirt] [PATCH] qemu: fix QEMU_CAPS_NO_ACPI detection

2013-01-16 Thread Ján Tomko
On 01/16/13 00:04, Eric Blake wrote: > On 12/21/2012 06:38 AM, Ján Tomko wrote: >> In commit c4bbaaf8, caps->arch was checked uninitialized, rendering the >> whole check useless. >> >> This patch moves the conditional setting of QEMU_CAPS_NO_ACPI to >> qemuCapsInitQMP, and removes the no longer nee

Re: [libvirt] [PATCH] qemu: fix QEMU_CAPS_NO_ACPI detection

2013-01-15 Thread Eric Blake
On 12/21/2012 06:38 AM, Ján Tomko wrote: > In commit c4bbaaf8, caps->arch was checked uninitialized, rendering the > whole check useless. > > This patch moves the conditional setting of QEMU_CAPS_NO_ACPI to > qemuCapsInitQMP, and removes the no longer needed exception for S390. > > It also clears

Re: [libvirt] [PATCH] qemu: fix QEMU_CAPS_NO_ACPI detection

2013-01-15 Thread Li Zhang
On 2013年01月15日 19:47, Ján Tomko wrote: On 12/21/12 14:38, Ján Tomko wrote: In commit c4bbaaf8, caps->arch was checked uninitialized, rendering the whole check useless. This patch moves the conditional setting of QEMU_CAPS_NO_ACPI to qemuCapsInitQMP, and removes the no longer needed exception fo

Re: [libvirt] [PATCH] qemu: fix QEMU_CAPS_NO_ACPI detection

2013-01-15 Thread Ján Tomko
On 12/21/12 14:38, Ján Tomko wrote: > In commit c4bbaaf8, caps->arch was checked uninitialized, rendering the > whole check useless. > > This patch moves the conditional setting of QEMU_CAPS_NO_ACPI to > qemuCapsInitQMP, and removes the no longer needed exception for S390. > > It also clears the

Re: [libvirt] [PATCH] qemu: fix QEMU_CAPS_NO_ACPI detection

2012-12-21 Thread Viktor Mihajlovski
On 12/21/2012 03:45 PM, Li Zhang wrote: On POWER, QEMU's help string doesn't include -no-acpi. It seems that QEMU handles this differently. :) it depends on the version: newer QEMUs for S390 don't include -no-acpi either ... but libvirt should remain compatible with older QEMUs -- Mit freundl

Re: [libvirt] [PATCH] qemu: fix QEMU_CAPS_NO_ACPI detection

2012-12-21 Thread Li Zhang
On Fri, Dec 21, 2012 at 10:20 PM, Ján Tomko wrote: > On 12/21/12 15:07, Li Zhang wrote: > > > > > > On Fri, Dec 21, 2012 at 9:38 PM, Ján Tomko > > wrote: > > > > In commit c4bbaaf8, caps->arch was checked uninitialized, rendering > the > > whole check useless. >

Re: [libvirt] [PATCH] qemu: fix QEMU_CAPS_NO_ACPI detection

2012-12-21 Thread Li Zhang
On Fri, Dec 21, 2012 at 10:37 PM, Viktor Mihajlovski < mihaj...@linux.vnet.ibm.com> wrote: > On 12/21/2012 03:07 PM, Li Zhang wrote: > >> >> Will it get QEMU_CAPS_NO_ACPI capability by QMP if S390 doesn't support >> ACPI? >> I test it on PPC, it won't get this capability by QMP. >> >> In the QMP

Re: [libvirt] [PATCH] qemu: fix QEMU_CAPS_NO_ACPI detection

2012-12-21 Thread Viktor Mihajlovski
On 12/21/2012 03:07 PM, Li Zhang wrote: Will it get QEMU_CAPS_NO_ACPI capability by QMP if S390 doesn't support ACPI? I test it on PPC, it won't get this capability by QMP. In the QMP case, basic capabilities are not being probed, but assumed to be present, however -no-acpi is only valid for x

Re: [libvirt] [PATCH] qemu: fix QEMU_CAPS_NO_ACPI detection

2012-12-21 Thread Ján Tomko
On 12/21/12 15:07, Li Zhang wrote: > > > On Fri, Dec 21, 2012 at 9:38 PM, Ján Tomko > wrote: > > In commit c4bbaaf8, caps->arch was checked uninitialized, rendering the > whole check useless. > > This patch moves the conditional setting of QEMU_CAPS_NO_ACP

Re: [libvirt] [PATCH] qemu: fix QEMU_CAPS_NO_ACPI detection

2012-12-21 Thread Li Zhang
On Fri, Dec 21, 2012 at 9:38 PM, Ján Tomko wrote: > In commit c4bbaaf8, caps->arch was checked uninitialized, rendering the > whole check useless. > > This patch moves the conditional setting of QEMU_CAPS_NO_ACPI to > qemuCapsInitQMP, and removes the no longer needed exception for S390. > > Will

Re: [libvirt] [PATCH] qemu: fix QEMU_CAPS_NO_ACPI detection

2012-12-21 Thread Viktor Mihajlovski
On 12/21/2012 02:38 PM, Ján Tomko wrote: In commit c4bbaaf8, caps->arch was checked uninitialized, rendering the whole check useless. This patch moves the conditional setting of QEMU_CAPS_NO_ACPI to qemuCapsInitQMP, and removes the no longer needed exception for S390. It also clears the flag fo

[libvirt] [PATCH] qemu: fix QEMU_CAPS_NO_ACPI detection

2012-12-21 Thread Ján Tomko
In commit c4bbaaf8, caps->arch was checked uninitialized, rendering the whole check useless. This patch moves the conditional setting of QEMU_CAPS_NO_ACPI to qemuCapsInitQMP, and removes the no longer needed exception for S390. It also clears the flag for all non-x86 archs instead of just S390 in