Re: [libvirt] [PATCH] qemu: fix domxml-to-native failing when spice_tls is not enabled

2014-07-09 Thread Ján Tomko
On 06/27/2014 04:37 PM, Jincheng Miao wrote: > The default graphics channel mode is 'any', so as to defaultMode attribute. > If defaultMode and channel mode are all the default value 'any', > qemuConnectDomainXMLToNative will set TLSPort. > But in qemuBuildGraphicsSPICECommandLine, if spice_tls is

Re: [libvirt] [PATCH] qemu: fix domxml-to-native failing when spice_tls is not enabled

2014-06-30 Thread Jincheng Miao
Well, I have some thought about this fix. For xml-to-native operation, user only need a qemu cmd pattern for a specified domain XML, so the qemu cmdline generated should be strained by qemu.conf. The function qemuBuildCommandLine(), called by qemuConnectDomainXMLToNative() and qemuProcessStart(

[libvirt] [PATCH] qemu: fix domxml-to-native failing when spice_tls is not enabled

2014-06-27 Thread Jincheng Miao
The default graphics channel mode is 'any', so as to defaultMode attribute. If defaultMode and channel mode are all the default value 'any', qemuConnectDomainXMLToNative will set TLSPort. But in qemuBuildGraphicsSPICECommandLine, if spice_tls is not enabled, libvirtd will report an error to tell th