Re: [libvirt] [PATCH] qemu: fix ethernet network type ip/route assign

2016-08-25 Thread Vasiliy Tolstov
2016-08-25 18:17 GMT+03:00 Laine Stump : > Until now, linkstate has always been used to control the online status of > the emulated NIC in the guest, and the tap device has always been IFF_UP > (and for a good reason. See my reply to you in the thread for my patches for > more

Re: [libvirt] [PATCH] qemu: fix ethernet network type ip/route assign

2016-08-25 Thread Laine Stump
On 08/25/2016 02:59 AM, Vasiliy Tolstov wrote: May be I miss something but in you patch you always up tap device, but if I create domain with link down in XML this not right. What do you think? Until now, linkstate has always been used to control the online status of the emulated NIC in

Re: [libvirt] [PATCH] qemu: fix ethernet network type ip/route assign

2016-08-25 Thread Vasiliy Tolstov
25 Авг 2016 г. 9:00 пользователь "Laine Stump" написал: > > On 08/24/2016 02:32 PM, Laine Stump wrote: >> >> On 08/24/2016 12:09 PM, Vasiliy Tolstov wrote: >>> >>> IP and routes assigenment incorrectly placed on device stop. >>> This is fixing it, also change device state

Re: [libvirt] [PATCH] qemu: fix ethernet network type ip/route assign

2016-08-25 Thread Vasiliy Tolstov
25 Авг 2016 г. 9:00 пользователь "Laine Stump" написал: > > On 08/24/2016 02:32 PM, Laine Stump wrote: >> >> On 08/24/2016 12:09 PM, Vasiliy Tolstov wrote: >>> >>> IP and routes assigenment incorrectly placed on device stop. >>> This is fixing it, also change device state

Re: [libvirt] [PATCH] qemu: fix ethernet network type ip/route assign

2016-08-25 Thread Laine Stump
On 08/24/2016 02:32 PM, Laine Stump wrote: On 08/24/2016 12:09 PM, Vasiliy Tolstov wrote: IP and routes assigenment incorrectly placed on device stop. This is fixing it, also change device state according to xml. Note that as i know in linux routes can't be created on device that does not up.

Re: [libvirt] [PATCH] qemu: fix ethernet network type ip/route assign

2016-08-24 Thread Laine Stump
On 08/24/2016 12:09 PM, Vasiliy Tolstov wrote: IP and routes assigenment incorrectly placed on device stop. This is fixing it, also change device state according to xml. Note that as i know in linux routes can't be created on device that does not up. Signed-off-by: Vasiliy Tolstov

Re: [libvirt] [PATCH] qemu: fix ethernet network type ip/route assign

2016-08-24 Thread Vasiliy Tolstov
2016-08-24 19:09 GMT+03:00 Vasiliy Tolstov : > IP and routes assigenment incorrectly placed on device stop. > This is fixing it, also change device state according to xml. > Note that as i know in linux routes can't be created on device that does > not up. Forget please,

[libvirt] [PATCH] qemu: fix ethernet network type ip/route assign

2016-08-24 Thread Vasiliy Tolstov
IP and routes assigenment incorrectly placed on device stop. This is fixing it, also change device state according to xml. Note that as i know in linux routes can't be created on device that does not up. Signed-off-by: Vasiliy Tolstov --- src/qemu/qemu_interface.c | 23

Re: [libvirt] [PATCH] qemu: fix ethernet network type ip/route assign

2016-08-24 Thread Daniel P. Berrange
On Wed, Aug 24, 2016 at 06:40:59PM +0300, Vasiliy Tolstov wrote: > IP and routes assigenment incorrectly placed on device stop. > This is fixing it, also change device state according to xml. > Note that as i know in linux routes can't be created on device that does > not up. > > Signed-off-by:

[libvirt] [PATCH] qemu: fix ethernet network type ip/route assign

2016-08-24 Thread Vasiliy Tolstov
IP and routes assigenment incorrectly placed on device stop. This is fixing it, also change device state according to xml. Note that as i know in linux routes can't be created on device that does not up. Signed-off-by: Vasiliy Tolstov --- src/qemu/qemu_interface.c | 23