Re: [libvirt] [PATCH] qemu: fix msg could be a wild pointer in qemuMonitorIOProcess()

2018-06-22 Thread Jiri Denemark
On Wed, Jun 20, 2018 at 16:45:27 +0800, Weilun Zhu wrote: > As qemuMonitorJSONIOProcess will call qemuMonitorJSONIOProcessEvent > which unlocks the monitor mutex, there is some extreme situation, > eg qemu send message to monitor twice in a short time, where the > local viriable 'msg' of

[libvirt] [PATCH] qemu: fix msg could be a wild pointer in qemuMonitorIOProcess()

2018-06-20 Thread Weilun Zhu
As qemuMonitorJSONIOProcess will call qemuMonitorJSONIOProcessEvent which unlocks the monitor mutex, there is some extreme situation, eg qemu send message to monitor twice in a short time, where the local viriable 'msg' of qemuMonitorIOProcess could be a wild point: 1. qemuMonitorSend() assign

Re: [libvirt] [PATCH] qemu: fix msg could be a wild pointer in qemuMonitorIOProcess()

2018-06-06 Thread Peter Krempa
On Wed, Jun 06, 2018 at 11:46:07 +0800, zhuweilun wrote: > > > 在 2018/6/5 15:10, Peter Krempa 写道: > > On Tue, Jun 05, 2018 at 10:14:39 +0800, Shannon Zhao wrote: > >> From: Weilun Zhu > >> > >> As qemuMonitorJSONIOProcess() will unlock the qemu monitor, there is > >> some extreme situation, eg

Re: [libvirt] [PATCH] qemu: fix msg could be a wild pointer in qemuMonitorIOProcess()

2018-06-06 Thread zhuweilun
在 2018/6/5 15:10, Peter Krempa 写道: > On Tue, Jun 05, 2018 at 10:14:39 +0800, Shannon Zhao wrote: >> From: Weilun Zhu >> >> As qemuMonitorJSONIOProcess() will unlock the qemu monitor, there is >> some extreme situation, eg qemu send message to monitor twice in a short >> time, where the local

Re: [libvirt] [PATCH] qemu: fix msg could be a wild pointer in qemuMonitorIOProcess()

2018-06-05 Thread Peter Krempa
On Tue, Jun 05, 2018 at 10:14:39 +0800, Shannon Zhao wrote: > From: Weilun Zhu > > As qemuMonitorJSONIOProcess() will unlock the qemu monitor, there is > some extreme situation, eg qemu send message to monitor twice in a short > time, where the local viriable 'msg' of qemuMonitorIOProcess()

[libvirt] [PATCH] qemu: fix msg could be a wild pointer in qemuMonitorIOProcess()

2018-06-04 Thread Shannon Zhao
From: Weilun Zhu As qemuMonitorJSONIOProcess() will unlock the qemu monitor, there is some extreme situation, eg qemu send message to monitor twice in a short time, where the local viriable 'msg' of qemuMonitorIOProcess() could be a wild point: 1. qemuMonitorSend() assign mon->msg to parameter