Re: [libvirt] [PATCH] qemu: handle more machines with a single builtin IDE controller

2015-11-23 Thread Guido Günther
On Sat, Nov 21, 2015 at 02:36:44PM -0500, Laine Stump wrote: > On 11/21/2015 02:00 PM, Guido Günther wrote: > >like I440FX by moving the condition into qemuDomainMachineHasBuiltinIDE > >and adding more machines. > > Nice! I like this better than the original 3 patch series, since it allows > recog

Re: [libvirt] [PATCH] qemu: handle more machines with a single builtin IDE controller

2015-11-21 Thread Laine Stump
On 11/21/2015 02:00 PM, Guido Günther wrote: like I440FX by moving the condition into qemuDomainMachineHasBuiltinIDE and adding more machines. Nice! I like this better than the original 3 patch series, since it allows recognizing any new machinetypes with a single line change. ACK, and thank

[libvirt] [PATCH] qemu: handle more machines with a single builtin IDE controller

2015-11-21 Thread Guido Günther
like I440FX by moving the condition into qemuDomainMachineHasBuiltinIDE and adding more machines. Reference: http://bugs.debian.org/805189 --- src/qemu/qemu_command.c | 26 ++ src/qemu/qemu_domain.c | 10 ++ src/qemu/qemu_domain.h | 1 + 3 files changed, 25 inse