[libvirt] [PATCH] qemu: keep capabilities when running QEMU as root

2019-12-04 Thread Daniel P . Berrangé
When QEMU uid/gid is set to non-root this is pointless as if we just used a regular setuid/setgid call, the process will have all its capabilities cleared anyway by the kernel. When QEMU uid/gid is set to root, this is almost (always?) never what people actually want. People make QEMU run as root

Re: [libvirt] [PATCH] qemu: keep capabilities when running QEMU as root

2019-12-11 Thread Daniel P . Berrangé
ping On Wed, Dec 04, 2019 at 10:11:47AM +, Daniel P. Berrangé wrote: > When QEMU uid/gid is set to non-root this is pointless as if we just > used a regular setuid/setgid call, the process will have all its > capabilities cleared anyway by the kernel. > > When QEMU uid/gid is set to root, thi

Re: [libvirt] [PATCH] qemu: keep capabilities when running QEMU as root

2019-12-11 Thread Cole Robinson
On 12/4/19 5:11 AM, Daniel P. Berrangé wrote: > When QEMU uid/gid is set to non-root this is pointless as if we just > used a regular setuid/setgid call, the process will have all its > capabilities cleared anyway by the kernel. > > When QEMU uid/gid is set to root, this is almost (always?) never

Re: [libvirt] [PATCH] qemu: keep capabilities when running QEMU as root

2019-12-11 Thread Daniel P . Berrangé
On Wed, Dec 11, 2019 at 10:25:32AM -0500, Cole Robinson wrote: > On 12/4/19 5:11 AM, Daniel P. Berrangé wrote: > > When QEMU uid/gid is set to non-root this is pointless as if we just > > used a regular setuid/setgid call, the process will have all its > > capabilities cleared anyway by the kernel.