Re: [libvirt] [PATCH] qemu: monitor: fix graceful shutdown corner cases

2017-09-26 Thread Nikolay Shirokovskiy
Please delay review, I plan to provide better patch. On 08.09.2017 10:16, Nikolay Shirokovskiy wrote: > Patch aeda1b8c needs some enhancement. > > 1. Shutdown event is delivired on reboot too and we don't want > to set willhangup flag is this case. > > 2. There is a next race condition. > > -

Re: [libvirt] [PATCH] qemu: monitor: fix graceful shutdown corner cases

2017-09-08 Thread Nikolay Shirokovskiy
Ouch, I don't escape test patch [1] in message body so is is applied together with the main patch. Be careful. On 08.09.2017 10:16, Nikolay Shirokovskiy wrote: > Patch aeda1b8c needs some enhancement. > > 1. Shutdown event is delivired on reboot too and we don't want > to set willhangup flag is t

[libvirt] [PATCH] qemu: monitor: fix graceful shutdown corner cases

2017-09-08 Thread Nikolay Shirokovskiy
Patch aeda1b8c needs some enhancement. 1. Shutdown event is delivired on reboot too and we don't want to set willhangup flag is this case. 2. There is a next race condition. - EOF is delivered in event loop thread - qemuMonitorSend is called on client behalf and waits for notification on me