Re: [libvirt] [PATCH] qemu: monitor: fix unsafe monitor access

2018-02-28 Thread Daniel P . Berrangé
On Thu, Mar 01, 2018 at 01:09:40AM +0800, Peng Hao wrote: > From: root You'll be wanting to fix your git author settings and then run "git commit --reset-author --amend" to fix existing commits. BTW, the clock on your machine sending the mail also seems to be incorrect by about 7 hours. Regards

Re: [libvirt] [PATCH] qemu: monitor: fix unsafe monitor access

2018-02-28 Thread Michal Privoznik
On 02/28/2018 06:09 PM, Peng Hao wrote: > From: root Don't you want to take credit for the patch? git config --global user.name "Mona Lisa" git config --global user.email "em...@example.com" > > qemuDomainObjExitMonitor is unsafe > > domain lock released when qemuDomainObjEnterMonitor finish,

Re: [libvirt] [PATCH] qemu: monitor: fix unsafe monitor access

2018-02-28 Thread Peter Krempa
On Thu, Mar 01, 2018 at 01:09:40 +0800, Peng Hao wrote: > From: root > > qemuDomainObjExitMonitor is unsafe > > domain lock released when qemuDomainObjEnterMonitor finish, > So other thread (qemuProcessStop) has chance to modify priv->mon > to NULL. qemuDomainObjExitMonitor will never release th

[libvirt] [PATCH] qemu: monitor: fix unsafe monitor access

2018-02-28 Thread Peng Hao
From: root qemuDomainObjExitMonitor is unsafe domain lock released when qemuDomainObjEnterMonitor finish, So other thread (qemuProcessStop) has chance to modify priv->mon to NULL. qemuDomainObjExitMonitor will never release the mon->lock, that may cause problem: thread get monitor ptr early, an