Re: [libvirt] [PATCH] qemu: process: comment on min_guarantee validation

2016-04-20 Thread Cole Robinson
On 04/20/2016 03:29 AM, Peter Krempa wrote: > On Tue, Apr 19, 2016 at 12:03:08 -0400, Cole Robinson wrote: >> It's not a matter of 'insist'ing or not; when in this area of the code I saw >> the min_guarantee check, which seemed out of place, since there are already >> several such checks in the pos

Re: [libvirt] [PATCH] qemu: process: comment on min_guarantee validation

2016-04-20 Thread Peter Krempa
On Tue, Apr 19, 2016 at 12:03:08 -0400, Cole Robinson wrote: > It's not a matter of 'insist'ing or not; when in this area of the code I saw > the min_guarantee check, which seemed out of place, since there are already > several such checks in the postparse handler.There's no comment explaining why

Re: [libvirt] [PATCH] qemu: process: comment on min_guarantee validation

2016-04-19 Thread Cole Robinson
On 04/19/2016 04:39 AM, Peter Krempa wrote: > On Mon, Apr 18, 2016 at 19:13:08 -0400, Cole Robinson wrote: >> Explain why we check it at process startup time, and not parse time >> where most other XML validation checks are performed > > This is far from being a singular case ... > >> --- >> src

Re: [libvirt] [PATCH] qemu: process: comment on min_guarantee validation

2016-04-19 Thread Peter Krempa
On Mon, Apr 18, 2016 at 19:13:08 -0400, Cole Robinson wrote: > Explain why we check it at process startup time, and not parse time > where most other XML validation checks are performed This is far from being a singular case ... > --- > src/qemu/qemu_process.c | 2 ++ > 1 file changed, 2 inserti

[libvirt] [PATCH] qemu: process: comment on min_guarantee validation

2016-04-18 Thread Cole Robinson
Explain why we check it at process startup time, and not parse time where most other XML validation checks are performed --- src/qemu/qemu_process.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index c087300..628b4b6 100644 --- a/src/qemu/