Re: [libvirt] [PATCH] qemu: qemuDomainChangeNet: don't overwrite device info when pci addr is missing

2018-08-05 Thread Ján Tomko
On Tue, Jul 31, 2018 at 04:34:39PM +0200, Katerina Koukiou wrote: When trying to update an interface's rom settings with an device XML that is missing the PCI addr element, all new rom settings where not applied. https://bugzilla.redhat.com/show_bug.cgi?id=1599513 Signed-off-by: Katerina

Re: [libvirt] [PATCH] qemu: qemuDomainChangeNet: don't overwrite device info when pci addr is missing

2018-08-01 Thread Katerina Koukiou
On Tue, Jul 31, 2018 at 07:24:00PM +0200, Ján Tomko wrote: > On Tue, Jul 31, 2018 at 05:32:51PM +0200, Katerina Koukiou wrote: > > On Tue, Jul 31, 2018 at 05:15:51PM +0200, Ján Tomko wrote: > > > On Tue, Jul 31, 2018 at 04:34:39PM +0200, Katerina Koukiou wrote: > > > > When trying to update an

Re: [libvirt] [PATCH] qemu: qemuDomainChangeNet: don't overwrite device info when pci addr is missing

2018-07-31 Thread Ján Tomko
On Tue, Jul 31, 2018 at 05:32:51PM +0200, Katerina Koukiou wrote: On Tue, Jul 31, 2018 at 05:15:51PM +0200, Ján Tomko wrote: On Tue, Jul 31, 2018 at 04:34:39PM +0200, Katerina Koukiou wrote: > When trying to update an interface's rom settings with an device XML > that is missing the PCI addr

Re: [libvirt] [PATCH] qemu: qemuDomainChangeNet: don't overwrite device info when pci addr is missing

2018-07-31 Thread Katerina Koukiou
On Tue, Jul 31, 2018 at 05:15:51PM +0200, Ján Tomko wrote: > On Tue, Jul 31, 2018 at 04:34:39PM +0200, Katerina Koukiou wrote: > > When trying to update an interface's rom settings with an device XML > > that is missing the PCI addr element, all new rom settings where not > > applied. > > > >

[libvirt] [PATCH] qemu: qemuDomainChangeNet: don't overwrite device info when pci addr is missing

2018-07-31 Thread Katerina Koukiou
When trying to update an interface's rom settings with an device XML that is missing the PCI addr element, all new rom settings where not applied. https://bugzilla.redhat.com/show_bug.cgi?id=1599513 Signed-off-by: Katerina Koukiou --- Not sure why we chose to overwrite the whole info before