[libvirt] [PATCH] qemu: qemuDomainChangeNet: validity checks should be done before XML autocompletion

2018-08-01 Thread Katerina Koukiou
We need to first perform the checks for changed/missing elements and then we can overwrite the missing ones. Otherwise we might falsely report successfull update, because some elements got overwritten before the validity checks. https://bugzilla.redhat.com/show_bug.cgi?id=1599513 Signed-off-by: K

Re: [libvirt] [PATCH] qemu: qemuDomainChangeNet: validity checks should be done before XML autocompletion

2018-08-06 Thread Ján Tomko
On Wed, Aug 01, 2018 at 12:37:13PM +0200, Katerina Koukiou wrote: We need to first perform the checks for changed/missing elements If we copy all the missing elements, and then we can overwrite the missing ones. Otherwise we might there's no need to overwrite them again. falsely report su