Re: [libvirt] [PATCH] qemu: reduce file padding requirements

2010-06-10 Thread Eric Blake
On 06/10/2010 05:20 AM, Daniel P. Berrange wrote: >> difference is that >file truncates; for block devices, truncation is a >> no-op, but for regular files, this wipes out any pre-existing contents >> (such as the header we are skipping over) - is that an issue? If so, >> then we should use <>file

Re: [libvirt] [PATCH] qemu: reduce file padding requirements

2010-06-10 Thread Daniel P. Berrange
On Thu, Jun 10, 2010 at 05:03:10AM -0600, Eric Blake wrote: > On 06/10/2010 04:16 AM, Daniel P. Berrange wrote: > >> > >> -if (virAsprintf(&dest, "exec:%s | dd of=%s bs=%llu seek=%llu", > >> -argstr, safe_target, > >> -QEMU_MONITOR_MIGRATE_TO_FILE_BS, > >

Re: [libvirt] [PATCH] qemu: reduce file padding requirements

2010-06-10 Thread Eric Blake
On 06/10/2010 04:16 AM, Daniel P. Berrange wrote: >> >> -if (virAsprintf(&dest, "exec:%s | dd of=%s bs=%llu seek=%llu", >> -argstr, safe_target, >> -QEMU_MONITOR_MIGRATE_TO_FILE_BS, >> -offset / QEMU_MONITOR_MIGRATE_TO_FILE_BS) < 0) {

Re: [libvirt] [PATCH] qemu: reduce file padding requirements

2010-06-10 Thread Daniel P. Berrange
On Wed, Jun 09, 2010 at 08:33:49PM -0600, Eric Blake wrote: > Followup to https://bugzilla.redhat.com/show_bug.cgi?id=599091, > commit 20206a4b, to reduce disk waste in padding. > > * src/qemu/qemu_monitor.h (QEMU_MONITOR_MIGRATE_TO_FILE_BS): Drop > back to 512. > (QEMU_MONITOR_MIGRATE_TO_FILE_TRA

[libvirt] [PATCH] qemu: reduce file padding requirements

2010-06-09 Thread Eric Blake
Followup to https://bugzilla.redhat.com/show_bug.cgi?id=599091, commit 20206a4b, to reduce disk waste in padding. * src/qemu/qemu_monitor.h (QEMU_MONITOR_MIGRATE_TO_FILE_BS): Drop back to 512. (QEMU_MONITOR_MIGRATE_TO_FILE_TRANSFER_SIZE): New macro. * src/qemu/qemu_driver.c (qemudDomainSaveFlag):