Re: [libvirt] [PATCH] qemu: snapshot: Keep non-persistent changes alive in snapshot

2017-10-30 Thread Madhu Pavan
On 10/27/2017 06:51 PM, Jiri Denemark wrote: On Fri, Oct 27, 2017 at 18:47:51 +0530, Madhu Pavan wrote: On 10/27/2017 02:51 PM, Jiri Denemark wrote: I think this is actually a bit more complicated. When reverting to a snapshot, when reverting a snapshot we should revert both active and inacti

Re: [libvirt] [PATCH] qemu: snapshot: Keep non-persistent changes alive in snapshot

2017-10-27 Thread Jiri Denemark
On Fri, Oct 27, 2017 at 18:47:51 +0530, Madhu Pavan wrote: > On 10/27/2017 02:51 PM, Jiri Denemark wrote: > > I think this is actually a bit more complicated. When reverting to a > > snapshot, when reverting a snapshot we should revert both active and > > inactive configuration for backward compati

Re: [libvirt] [PATCH] qemu: snapshot: Keep non-persistent changes alive in snapshot

2017-10-27 Thread Madhu Pavan
On 10/27/2017 02:51 PM, Jiri Denemark wrote: On Fri, Oct 27, 2017 at 14:02:23 +0530, Kothapally Madhu Pavan wrote: Restoring to a snapshot should not overwrite the persistent configuration xml of a snapshot as a side effect. This patch fixes the same. Currently, virDomainSnapshotDef only saves

Re: [libvirt] [PATCH] qemu: snapshot: Keep non-persistent changes alive in snapshot

2017-10-27 Thread Jiri Denemark
On Fri, Oct 27, 2017 at 14:02:23 +0530, Kothapally Madhu Pavan wrote: > Restoring to a snapshot should not overwrite the persistent configuration > xml of a snapshot as a side effect. This patch fixes the same. Currently, > virDomainSnapshotDef only saves active domain definition of the guest. > An

[libvirt] [PATCH] qemu: snapshot: Keep non-persistent changes alive in snapshot

2017-10-27 Thread Kothapally Madhu Pavan
Restoring to a snapshot should not overwrite the persistent configuration xml of a snapshot as a side effect. This patch fixes the same. Currently, virDomainSnapshotDef only saves active domain definition of the guest. And on restore the active domain definition is used as both active and inactive