Re: [libvirt] [PATCH] qemu: update qemuCgroupControllerActive signature

2011-05-04 Thread Eric Blake
On 05/03/2011 11:02 PM, Laine Stump wrote: On 05/03/2011 04:22 PM, Eric Blake wrote: Clang warned about a dead assignment. In the process, I noticed that we are only using the function for a bool value. I audited all other callers in qemu_{migration,cgroup,driver,hotplug), and all were

[libvirt] [PATCH] qemu: update qemuCgroupControllerActive signature

2011-05-03 Thread Eric Blake
Clang warned about a dead assignment. In the process, I noticed that we are only using the function for a bool value. I audited all other callers in qemu_{migration,cgroup,driver,hotplug), and all were making the call in a bool context. * src/qemu/qemu_cgroup.c (qemuSetupCgroup): Delete dead

Re: [libvirt] [PATCH] qemu: update qemuCgroupControllerActive signature

2011-05-03 Thread Laine Stump
On 05/03/2011 04:22 PM, Eric Blake wrote: Clang warned about a dead assignment. In the process, I noticed that we are only using the function for a bool value. I audited all other callers in qemu_{migration,cgroup,driver,hotplug), and all were making the call in a bool context. *