Re: [libvirt] [PATCH] qemu: use "ide" as device name for implicit SATA controller on Q35

2013-09-20 Thread Daniel P. Berrange
On Fri, Sep 20, 2013 at 10:15:30AM -0400, Laine Stump wrote: > On 09/20/2013 09:33 AM, Daniel P. Berrange wrote: > > On Fri, Sep 20, 2013 at 06:25:10AM -0400, Laine Stump wrote: > >> This resolves https://bugzilla.redhat.com/show_bug.cgi?id=1008903 > >> > >> The Q35 machinetype has an implicit SATA

Re: [libvirt] [PATCH] qemu: use "ide" as device name for implicit SATA controller on Q35

2013-09-20 Thread Daniel P. Berrange
On Fri, Sep 20, 2013 at 04:35:12PM +0200, Gerd Hoffmann wrote: > Hi, > > > 1) Every SATA controller has 6 buses, and each bus allows a single > > target (or "unit"). > > That is how it is modeled in qemu, largely due to reusing the ide code. > > On real hardware you have a sata controller with

Re: [libvirt] [PATCH] qemu: use "ide" as device name for implicit SATA controller on Q35

2013-09-20 Thread Eric Blake
On 09/20/2013 08:15 AM, Laine Stump wrote: > > This will leave one problem - what to do if someone migrates a guest > with the new non-0 unit# to a host that's still running old libvirt that > ignores unit#. I don't see how to get around this problem without having > knowledge of the source and

Re: [libvirt] [PATCH] qemu: use "ide" as device name for implicit SATA controller on Q35

2013-09-20 Thread Gerd Hoffmann
Hi, > 1) Every SATA controller has 6 buses, and each bus allows a single > target (or "unit"). That is how it is modeled in qemu, largely due to reusing the ide code. On real hardware you have a sata controller with a number of ports (happens to be 6 for the one emulated by qemu, but that may

Re: [libvirt] [PATCH] qemu: use "ide" as device name for implicit SATA controller on Q35

2013-09-20 Thread Laine Stump
On 09/20/2013 09:33 AM, Daniel P. Berrange wrote: > On Fri, Sep 20, 2013 at 06:25:10AM -0400, Laine Stump wrote: >> This resolves https://bugzilla.redhat.com/show_bug.cgi?id=1008903 >> >> The Q35 machinetype has an implicit SATA controller at 00:1F.2 which >> isn't given the "expected" id of ahci0

Re: [libvirt] [PATCH] qemu: use "ide" as device name for implicit SATA controller on Q35

2013-09-20 Thread Daniel P. Berrange
On Fri, Sep 20, 2013 at 06:25:10AM -0400, Laine Stump wrote: > This resolves https://bugzilla.redhat.com/show_bug.cgi?id=1008903 > > The Q35 machinetype has an implicit SATA controller at 00:1F.2 which > isn't given the "expected" id of ahci0 by qemu when it's created. The > original suggested sol

Re: [libvirt] [PATCH] qemu: use "ide" as device name for implicit SATA controller on Q35

2013-09-20 Thread Ján Tomko
On 09/20/2013 12:25 PM, Laine Stump wrote: > This resolves https://bugzilla.redhat.com/show_bug.cgi?id=1008903 > > The Q35 machinetype has an implicit SATA controller at 00:1F.2 which > isn't given the "expected" id of ahci0 by qemu when it's created. The > original suggested solution to this prob

[libvirt] [PATCH] qemu: use "ide" as device name for implicit SATA controller on Q35

2013-09-20 Thread Laine Stump
This resolves https://bugzilla.redhat.com/show_bug.cgi?id=1008903 The Q35 machinetype has an implicit SATA controller at 00:1F.2 which isn't given the "expected" id of ahci0 by qemu when it's created. The original suggested solution to this problem was to not specify any controller for the disks t