Re: [libvirt] [PATCH] qemu migration: assign addresses in xml passed as parameter

2016-03-19 Thread Nikolay Shirokovskiy
On 15.03.2016 21:24, Jiri Denemark wrote: > On Tue, Feb 09, 2016 at 11:36:32 +0300, Nikolay Shirokovskiy wrote: >> Usecase: >> >> 1. define domain with xml A where addresses are not set >> 2. migrate with '--xml A' > > This use case is incorrect. To make sure the ABI compatibility checks > pass,

Re: [libvirt] [PATCH] qemu migration: assign addresses in xml passed as parameter

2016-03-15 Thread Jiri Denemark
On Tue, Feb 09, 2016 at 11:36:32 +0300, Nikolay Shirokovskiy wrote: > Usecase: > > 1. define domain with xml A where addresses are not set > 2. migrate with '--xml A' This use case is incorrect. To make sure the ABI compatibility checks pass, you should take the XML back from libvirt. In addition

[libvirt] [PATCH] qemu migration: assign addresses in xml passed as parameter

2016-02-09 Thread Nikolay Shirokovskiy
Usecase: 1. define domain with xml A where addresses are not set 2. migrate with '--xml A' You get ABI incompatibility because we comprare xmls with addresses set and not. This patch assign addresses in parameter xml so the comprasion is fair. Signed-off-by: Nikolay Shirokovskiy --- src/qemu/q