Re: [libvirt] [PATCH] qemuDomainAttachDeviceLive: Check provided disk address

2015-09-30 Thread Martin Kletzander
On Wed, Sep 30, 2015 at 09:44:27AM -0400, John Ferlan wrote: On 09/30/2015 12:43 AM, Martin Kletzander wrote: On Tue, Sep 29, 2015 at 05:27:58PM -0400, John Ferlan wrote: [...] NOTE: The change to the test is because the failure now occurs during parse rather than at run (e.g. earlier, wh

Re: [libvirt] [PATCH] qemuDomainAttachDeviceLive: Check provided disk address

2015-09-30 Thread John Ferlan
On 09/30/2015 12:43 AM, Martin Kletzander wrote: > On Tue, Sep 29, 2015 at 05:27:58PM -0400, John Ferlan wrote: [...] >> >> NOTE: The change to the test is because the failure now occurs during >> parse rather than at run (e.g. earlier, where I think it should). > > I agree, and this sounds go

Re: [libvirt] [PATCH] qemuDomainAttachDeviceLive: Check provided disk address

2015-09-29 Thread Martin Kletzander
On Tue, Sep 29, 2015 at 05:27:58PM -0400, John Ferlan wrote: On 09/29/2015 11:03 AM, Michal Privoznik wrote: On 25.09.2015 14:45, Martin Kletzander wrote: On Fri, Sep 25, 2015 at 06:41:44AM -0400, John Ferlan wrote: On 09/25/2015 05:38 AM, Michal Privoznik wrote: On 25.09.2015 11:36, Mart

Re: [libvirt] [PATCH] qemuDomainAttachDeviceLive: Check provided disk address

2015-09-29 Thread John Ferlan
On 09/29/2015 11:03 AM, Michal Privoznik wrote: > On 25.09.2015 14:45, Martin Kletzander wrote: >> On Fri, Sep 25, 2015 at 06:41:44AM -0400, John Ferlan wrote: >>> >>> >>> On 09/25/2015 05:38 AM, Michal Privoznik wrote: On 25.09.2015 11:36, Martin Kletzander wrote: > On Thu, Sep 24, 2015

Re: [libvirt] [PATCH] qemuDomainAttachDeviceLive: Check provided disk address

2015-09-29 Thread Martin Kletzander
On Tue, Sep 29, 2015 at 05:03:07PM +0200, Michal Privoznik wrote: On 25.09.2015 14:45, Martin Kletzander wrote: On Fri, Sep 25, 2015 at 06:41:44AM -0400, John Ferlan wrote: On 09/25/2015 05:38 AM, Michal Privoznik wrote: On 25.09.2015 11:36, Martin Kletzander wrote: On Thu, Sep 24, 2015 at

Re: [libvirt] [PATCH] qemuDomainAttachDeviceLive: Check provided disk address

2015-09-29 Thread Michal Privoznik
On 25.09.2015 14:45, Martin Kletzander wrote: > On Fri, Sep 25, 2015 at 06:41:44AM -0400, John Ferlan wrote: >> >> >> On 09/25/2015 05:38 AM, Michal Privoznik wrote: >>> On 25.09.2015 11:36, Martin Kletzander wrote: On Thu, Sep 24, 2015 at 05:43:08PM +0200, Michal Privoznik wrote: > https:

Re: [libvirt] [PATCH] qemuDomainAttachDeviceLive: Check provided disk address

2015-09-25 Thread Martin Kletzander
On Fri, Sep 25, 2015 at 06:41:44AM -0400, John Ferlan wrote: On 09/25/2015 05:38 AM, Michal Privoznik wrote: On 25.09.2015 11:36, Martin Kletzander wrote: On Thu, Sep 24, 2015 at 05:43:08PM +0200, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1257844 Imagine an user wh

Re: [libvirt] [PATCH] qemuDomainAttachDeviceLive: Check provided disk address

2015-09-25 Thread John Ferlan
On 09/25/2015 05:38 AM, Michal Privoznik wrote: > On 25.09.2015 11:36, Martin Kletzander wrote: >> On Thu, Sep 24, 2015 at 05:43:08PM +0200, Michal Privoznik wrote: >>> https://bugzilla.redhat.com/show_bug.cgi?id=1257844 >>> >>> Imagine an user who is trying to attach a disk to a domain with >>>

Re: [libvirt] [PATCH] qemuDomainAttachDeviceLive: Check provided disk address

2015-09-25 Thread Michal Privoznik
On 25.09.2015 11:36, Martin Kletzander wrote: > On Thu, Sep 24, 2015 at 05:43:08PM +0200, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1257844 >> >> Imagine an user who is trying to attach a disk to a domain with >> the following XML: >> >> >> >> >> >> >>

Re: [libvirt] [PATCH] qemuDomainAttachDeviceLive: Check provided disk address

2015-09-25 Thread Martin Kletzander
On Thu, Sep 24, 2015 at 05:43:08PM +0200, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1257844 Imagine an user who is trying to attach a disk to a domain with the following XML: The XML is obviously wrong. It's trying to attach a virtio disk onto non-

[libvirt] [PATCH] qemuDomainAttachDeviceLive: Check provided disk address

2015-09-24 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=1257844 Imagine an user who is trying to attach a disk to a domain with the following XML: The XML is obviously wrong. It's trying to attach a virtio disk onto non-PCI bus. We should forbid that. Signed-off-by: Michal Privozn