Re: [libvirt] [PATCH] qemuDomainRename: Report error if adding domain to domainObj list fails

2015-08-17 Thread Martin Kletzander
On Mon, Aug 17, 2015 at 02:27:57PM -0700, Martin Kletzander wrote: On Fri, Aug 14, 2015 at 03:40:16PM +0200, Michal Privoznik wrote: So, domain renaming works like this: new domain name is added into the list of domain objects. Then, domain definition is updated. After that, old domain name is r

Re: [libvirt] [PATCH] qemuDomainRename: Report error if adding domain to domainObj list fails

2015-08-17 Thread Martin Kletzander
On Mon, Aug 17, 2015 at 11:45:09PM +0200, Michal Privoznik wrote: On 17.08.2015 23:27, Martin Kletzander wrote: On Fri, Aug 14, 2015 at 03:40:16PM +0200, Michal Privoznik wrote: So, domain renaming works like this: new domain name is added into the list of domain objects. Then, domain definitio

Re: [libvirt] [PATCH] qemuDomainRename: Report error if adding domain to domainObj list fails

2015-08-17 Thread Michal Privoznik
On 17.08.2015 23:27, Martin Kletzander wrote: > On Fri, Aug 14, 2015 at 03:40:16PM +0200, Michal Privoznik wrote: >> So, domain renaming works like this: new domain name is added >> into the list of domain objects. Then, domain definition is >> updated. After that, old domain name is removed from t

Re: [libvirt] [PATCH] qemuDomainRename: Report error if adding domain to domainObj list fails

2015-08-17 Thread Martin Kletzander
On Fri, Aug 14, 2015 at 03:40:16PM +0200, Michal Privoznik wrote: So, domain renaming works like this: new domain name is added into the list of domain objects. Then, domain definition is updated. After that, old domain name is removed from the domain object list. Now, if the very firs step fails

Re: [libvirt] [PATCH] qemuDomainRename: Report error if adding domain to domainObj list fails

2015-08-17 Thread Martin Kletzander
On Mon, Aug 17, 2015 at 08:39:29PM +0200, Michal Privoznik wrote: On 15.08.2015 16:26, Martin Kletzander wrote: On Fri, Aug 14, 2015 at 03:40:16PM +0200, Michal Privoznik wrote: So, domain renaming works like this: new domain name is added into the list of domain objects. Then, domain definitio

Re: [libvirt] [PATCH] qemuDomainRename: Report error if adding domain to domainObj list fails

2015-08-17 Thread Michal Privoznik
On 15.08.2015 16:26, Martin Kletzander wrote: > On Fri, Aug 14, 2015 at 03:40:16PM +0200, Michal Privoznik wrote: >> So, domain renaming works like this: new domain name is added >> into the list of domain objects. Then, domain definition is >> updated. After that, old domain name is removed from t

Re: [libvirt] [PATCH] qemuDomainRename: Report error if adding domain to domainObj list fails

2015-08-15 Thread Martin Kletzander
On Fri, Aug 14, 2015 at 03:40:16PM +0200, Michal Privoznik wrote: So, domain renaming works like this: new domain name is added into the list of domain objects. Then, domain definition is updated. After that, old domain name is removed from the domain object list. Now, if the very firs step fails

[libvirt] [PATCH] qemuDomainRename: Report error if adding domain to domainObj list fails

2015-08-14 Thread Michal Privoznik
So, domain renaming works like this: new domain name is added into the list of domain objects. Then, domain definition is updated. After that, old domain name is removed from the domain object list. Now, if the very firs step fails for some reason, no error is reported: virsh # domrename dummy dum