Re: [libvirt] [PATCH] qemuDomainSnapshotCreateActiveExternal: Remove memory snapshot on failure less frequently

2018-08-30 Thread Peter Krempa
On Thu, Aug 30, 2018 at 13:06:40 +0200, Michal Privoznik wrote: > On 08/30/2018 12:57 PM, Peter Krempa wrote: > > On Thu, Aug 30, 2018 at 11:22:35 +0200, Michal Privoznik wrote: > >> https://bugzilla.redhat.com/show_bug.cgi?id=1589115 > >> > >> When creating a memory snapshot the domain is

Re: [libvirt] [PATCH] qemuDomainSnapshotCreateActiveExternal: Remove memory snapshot on failure less frequently

2018-08-30 Thread Michal Privoznik
On 08/30/2018 12:57 PM, Peter Krempa wrote: > On Thu, Aug 30, 2018 at 11:22:35 +0200, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1589115 >> >> When creating a memory snapshot the domain is suspended and qemu >> is told to dump memory into the desired file. After that we

Re: [libvirt] [PATCH] qemuDomainSnapshotCreateActiveExternal: Remove memory snapshot on failure less frequently

2018-08-30 Thread Peter Krempa
On Thu, Aug 30, 2018 at 11:22:35 +0200, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1589115 > > When creating a memory snapshot the domain is suspended and qemu > is told to dump memory into the desired file. After that we set a > flag so that the file is not left behind

[libvirt] [PATCH] qemuDomainSnapshotCreateActiveExternal: Remove memory snapshot on failure less frequently

2018-08-30 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=1589115 When creating a memory snapshot the domain is suspended and qemu is told to dump memory into the desired file. After that we set a flag so that the file is not left behind if a failure occurs at some later point (e.g. when creating disk snapshot