Re: [libvirt] [PATCH] qemuDomainSnapshotCreateXML: Don't leak parsed snapshot definition

2019-05-14 Thread Eric Blake
On 5/14/19 8:52 AM, Michal Privoznik wrote: > This function gets snapshot XML (provided by used) as an > argument. It parses it into a local variable @def and then sets > some more members (e.g. it creates a copy of live domain XML). > Then it proceeds to checking if snapshot XML is valid (e.g. it

Re: [libvirt] [PATCH] qemuDomainSnapshotCreateXML: Don't leak parsed snapshot definition

2019-05-14 Thread Erik Skultety
On Tue, May 14, 2019 at 03:52:07PM +0200, Michal Privoznik wrote: > This function gets snapshot XML (provided by used) as an > argument. It parses it into a local variable @def and then sets > some more members (e.g. it creates a copy of live domain XML). > Then it proceeds to checking if snapshot

[libvirt] [PATCH] qemuDomainSnapshotCreateXML: Don't leak parsed snapshot definition

2019-05-14 Thread Michal Privoznik
This function gets snapshot XML (provided by used) as an argument. It parses it into a local variable @def and then sets some more members (e.g. it creates a copy of live domain XML). Then it proceeds to checking if snapshot XML is valid (e.g. it contains as many disks as currently in the domain).