Re: [libvirt] [PATCH] qemu_agent: Issue guest-sync prior to every command

2012-02-07 Thread Daniel P. Berrange
On Wed, Feb 01, 2012 at 06:04:45PM +0100, Michal Privoznik wrote: If we issue guest command and GA is not running, the issuing thread will block endlessly. We can check for GA presence by issuing guest-sync with unique ID (timestamp). We don't want to issue real command as even if GA is not

Re: [libvirt] [PATCH] qemu_agent: Issue guest-sync prior to every command

2012-02-07 Thread Michal Privoznik
On 07.02.2012 16:18, Daniel P. Berrange wrote: On Wed, Feb 01, 2012 at 06:04:45PM +0100, Michal Privoznik wrote: If we issue guest command and GA is not running, the issuing thread will block endlessly. We can check for GA presence by issuing guest-sync with unique ID (timestamp). We don't

Re: [libvirt] [PATCH] qemu_agent: Issue guest-sync prior to every command

2012-02-07 Thread Eric Blake
On 02/07/2012 08:49 AM, Michal Privoznik wrote: We could still timeout the 'fs-freeze' command after 30 seconds or so. Given that we issue the guest-resync command, we'll be able to automatically re-sync the JSON protocol by dropping the later arriving fs-freeze reply (if any). I don't

[libvirt] [PATCH] qemu_agent: Issue guest-sync prior to every command

2012-02-01 Thread Michal Privoznik
If we issue guest command and GA is not running, the issuing thread will block endlessly. We can check for GA presence by issuing guest-sync with unique ID (timestamp). We don't want to issue real command as even if GA is not running, once it is started, it process all commands written to GA