Re: [libvirt] [PATCH] qemu_agent: report VIR_ERR_AGENT_UNSYNCED if guest_sync failed.

2017-11-30 Thread Nikolay Shirokovskiy
On 30.11.2017 13:37, Chen Hanxiao wrote: > > At 2017-11-30 14:11:36, "Nikolay Shirokovskiy" > wrote: >> >> >> On 30.11.2017 06:08, Chen Hanxiao wrote: >>> From: Chen Hanxiao >>> >>> Commit 5e5019bf removed this kind of error. >>> >>> But

Re: [libvirt] [PATCH] qemu_agent: report VIR_ERR_AGENT_UNSYNCED if guest_sync failed.

2017-11-30 Thread Chen Hanxiao
At 2017-11-30 14:11:36, "Nikolay Shirokovskiy" wrote: > > >On 30.11.2017 06:08, Chen Hanxiao wrote: >> From: Chen Hanxiao >> >> Commit 5e5019bf removed this kind of error. >> >> But we've already protected race condition by

Re: [libvirt] [PATCH] qemu_agent: report VIR_ERR_AGENT_UNSYNCED if guest_sync failed.

2017-11-29 Thread Nikolay Shirokovskiy
On 30.11.2017 06:08, Chen Hanxiao wrote: > From: Chen Hanxiao > > Commit 5e5019bf removed this kind of error. > > But we've already protected race condition by qemuDomainObjEnterAgent, > it was very unlikely to revieve a sync from other calls. > For call from

[libvirt] [PATCH] qemu_agent: report VIR_ERR_AGENT_UNSYNCED if guest_sync failed.

2017-11-29 Thread Chen Hanxiao
From: Chen Hanxiao Commit 5e5019bf removed this kind of error. But we've already protected race condition by qemuDomainObjEnterAgent, it was very unlikely to revieve a sync from other calls. For call from virDomain*, it's better to show this error if we really got a