Re: [libvirt] [PATCH] qemu_agent: support qemu agent general command

2012-08-06 Thread Eric Blake
On 08/05/2012 04:49 PM, MATSUDA, Daiki wrote: ACK or do I need to re-write ? Given this earlier review... Rather than just 2 flags, can we take an integer timeout parameter? If the parameter is -1, then we don't wait; if the parameter is 0, then we wait forever, otherwise, we wait for the

Re: [libvirt] [PATCH] qemu_agent: support qemu agent general command

2012-08-05 Thread MATSUDA, Daiki
ACK or do I need to re-write ? Regards MATSUDA Daiki On 07/13/2012 08:02 AM, Michal Privoznik wrote: On 13.07.2012 15:41, Eric Blake wrote: On 07/13/2012 06:25 AM, Michal Privoznik wrote: On 09.07.2012 12:54, Michal Privoznik wrote: [I am pasting your patch here again so I can point out

Re: [libvirt] [PATCH] qemu_agent: support qemu agent general command

2012-07-13 Thread Michal Privoznik
On 09.07.2012 12:54, Michal Privoznik wrote: [I am pasting your patch here again so I can point out some nits] On 06.07.2012 03:29, MATSUDA, Daiki wrote: However, I will hold the push for a while. There is one general problem with this patch. Unlike qemu monitor, guest agent has several

Re: [libvirt] [PATCH] qemu_agent: support qemu agent general command

2012-07-13 Thread Eric Blake
On 07/13/2012 06:25 AM, Michal Privoznik wrote: On 09.07.2012 12:54, Michal Privoznik wrote: [I am pasting your patch here again so I can point out some nits] On 06.07.2012 03:29, MATSUDA, Daiki wrote: However, I will hold the push for a while. There is one general problem with this

Re: [libvirt] [PATCH] qemu_agent: support qemu agent general command

2012-07-13 Thread Michal Privoznik
On 13.07.2012 15:41, Eric Blake wrote: On 07/13/2012 06:25 AM, Michal Privoznik wrote: On 09.07.2012 12:54, Michal Privoznik wrote: [I am pasting your patch here again so I can point out some nits] On 06.07.2012 03:29, MATSUDA, Daiki wrote: However, I will hold the push for a while. There

Re: [libvirt] [PATCH] qemu_agent: support qemu agent general command

2012-07-13 Thread Eric Blake
On 07/13/2012 08:02 AM, Michal Privoznik wrote: On 13.07.2012 15:41, Eric Blake wrote: On 07/13/2012 06:25 AM, Michal Privoznik wrote: On 09.07.2012 12:54, Michal Privoznik wrote: [I am pasting your patch here again so I can point out some nits] On 06.07.2012 03:29, MATSUDA, Daiki wrote:

Re: [libvirt] [PATCH] qemu_agent: support qemu agent general command

2012-07-09 Thread Michal Privoznik
[I am pasting your patch here again so I can point out some nits] On 06.07.2012 03:29, MATSUDA, Daiki wrote: diff -uNrp libvirt-0.9.13.orig/docs/hvsupport.pl libvirt-0.9.13/docs/hvsupport.pl --- libvirt-0.9.13.orig/docs/hvsupport.pl 2011-06-10 15:50:11.0 +0900 +++

[libvirt] [PATCH] qemu_agent: support qemu agent general command

2012-07-05 Thread MATSUDA, Daiki
Hi, All. Thank you for many comments. And I extremely apologize not to use git... My company's network closes the almost port and only http via proxy and simple mail are available. The attached patch is reflected all comments. Especially, diff -uNrp libvirt-0.9.13.orig/src/driver.h