Re: [libvirt] [PATCH] qemu_hotplug: Initialize @charAlias in qemuDomainRemoveChrDevice

2019-02-14 Thread John Ferlan
On 2/14/19 8:31 AM, Michal Privoznik wrote: > My change in 112f3a8d0f32 was too drastic. The @charAlias > variable is initialized only if @monitor == true. However, it is > used even outside of that condition, at which point it's just > uninitialized pointer. > > Reported-by: John Ferlan >

[libvirt] [PATCH] qemu_hotplug: Initialize @charAlias in qemuDomainRemoveChrDevice

2019-02-14 Thread Michal Privoznik
My change in 112f3a8d0f32 was too drastic. The @charAlias variable is initialized only if @monitor == true. However, it is used even outside of that condition, at which point it's just uninitialized pointer. Reported-by: John Ferlan Signed-off-by: Michal Privoznik --- src/qemu/qemu_hotplug.c |