Re: [libvirt] [PATCH] qemud: don't dereference NULL on failed virGetUserDirectory

2009-01-26 Thread Richard W.M. Jones
On Fri, Jan 23, 2009 at 02:23:14PM +0100, Jim Meyering wrote: > Jim Meyering wrote: > > I spotted this while merging my unix_sock_dir changes: > ... > > char *userdir = virGetUserDirectory(NULL, uid); > > +if (userdir == NULL) { > > +/* give no diagnostic here; virGetU

Re: [libvirt] [PATCH] qemud: don't dereference NULL on failed virGetUserDirectory

2009-01-23 Thread Daniel P. Berrange
On Fri, Jan 23, 2009 at 02:23:14PM +0100, Jim Meyering wrote: > Jim Meyering wrote: > > I spotted this while merging my unix_sock_dir changes: > ... > > char *userdir = virGetUserDirectory(NULL, uid); > > +if (userdir == NULL) { > > +/* give no diagnostic here; virGetU

Re: [libvirt] [PATCH] qemud: don't dereference NULL on failed virGetUserDirectory

2009-01-23 Thread Jim Meyering
Jim Meyering wrote: > I spotted this while merging my unix_sock_dir changes: ... > char *userdir = virGetUserDirectory(NULL, uid); > +if (userdir == NULL) { > +/* give no diagnostic here; virGetUserDirectory reports OOM */ It can also fail due to getpwuid_r failure.

[libvirt] [PATCH] qemud: don't dereference NULL on failed virGetUserDirectory

2009-01-23 Thread Jim Meyering
I spotted this while merging my unix_sock_dir changes: >From 04373207bc838c31bd07596df3c676476e73c983 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Fri, 23 Jan 2009 13:59:28 +0100 Subject: [PATCH] qemud: don't dereference NULL on failed virGetUserDirectory * qemud/qemud.c (qemudInitPaths): C