Re: [libvirt] [PATCH] remote: avoid null dereference on error

2011-05-04 Thread Daniel P. Berrange
On Tue, May 03, 2011 at 11:28:30AM -0600, Eric Blake wrote: Clang found three instances of uninitialized use of nparams in the cleanup path. Unfortunately, one is a false positive: clang couldn't see that ret-params.params_val is guaranteed to be NULL unless allocated within a function, and

Re: [libvirt] [PATCH] remote: avoid null dereference on error

2011-05-04 Thread Eric Blake
On 05/04/2011 10:38 AM, Daniel P. Berrange wrote: On Tue, May 03, 2011 at 11:28:30AM -0600, Eric Blake wrote: Clang found three instances of uninitialized use of nparams in the cleanup path. Unfortunately, one is a false positive: clang couldn't see that ret-params.params_val is guaranteed to

[libvirt] [PATCH] remote: avoid null dereference on error

2011-05-03 Thread Eric Blake
Clang found three instances of uninitialized use of nparams in the cleanup path. Unfortunately, one is a false positive: clang couldn't see that ret-params.params_val is guaranteed to be NULL unless allocated within a function, and that nparams is guaranteed to be assigned prior to the

Re: [libvirt] [PATCH] remote: avoid null dereference on error

2011-05-03 Thread Eric Blake
On 05/03/2011 11:28 AM, Eric Blake wrote: Clang found three instances of uninitialized use of nparams in the cleanup path. Unfortunately, one is a false positive: clang couldn't see that ret-params.params_val is guaranteed to be NULL unless allocated within a function, and that nparams is