[libvirt] [PATCH] remote generator: Handle struct returning functions better

2011-06-15 Thread Matthias Bolte
The position of the struct parameter in the function signature differs. Instead of hardcoding the handling for this add an annotation to the .x file to define the position. --- daemon/remote_generator.pl | 42 -- src/remote/remote_protocol.x | 23

Re: [libvirt] [PATCH] remote generator: Handle struct returning functions better

2011-06-15 Thread Eric Blake
On 06/15/2011 07:42 AM, Matthias Bolte wrote: The position of the struct parameter in the function signature differs. Instead of hardcoding the handling for this add an annotation to the .x file to define the position. --- daemon/remote_generator.pl | 42

Re: [libvirt] [PATCH] remote generator: Handle struct returning functions better

2011-06-15 Thread Matthias Bolte
2011/6/15 Eric Blake ebl...@redhat.com: On 06/15/2011 07:42 AM, Matthias Bolte wrote: The position of the struct parameter in the function signature differs. Instead of hardcoding the handling for this add an annotation to the .x file to define the position. ---  daemon/remote_generator.pl  

[libvirt] [PATCH] remote generator: Handle struct returning functions better (part 2)

2011-06-15 Thread Matthias Bolte
Commit 64000eabedf2 is part 1, that only covered the daemon side by accident. Part 2 covers the client side too. --- daemon/remote_generator.pl | 17 + 1 files changed, 5 insertions(+), 12 deletions(-) diff --git a/daemon/remote_generator.pl b/daemon/remote_generator.pl index

Re: [libvirt] [PATCH] remote generator: Handle struct returning functions better (part 2)

2011-06-15 Thread Eric Blake
On 06/15/2011 09:35 AM, Matthias Bolte wrote: Commit 64000eabedf2 is part 1, that only covered the daemon side by accident. Part 2 covers the client side too. --- daemon/remote_generator.pl | 17 + 1 files changed, 5 insertions(+), 12 deletions(-) ACK. -- Eric Blake

Re: [libvirt] [PATCH] remote generator: Handle struct returning functions better (part 2)

2011-06-15 Thread Matthias Bolte
2011/6/15 Eric Blake ebl...@redhat.com: On 06/15/2011 09:35 AM, Matthias Bolte wrote: Commit 64000eabedf2 is part 1, that only covered the daemon side by accident. Part 2 covers the client side too. ---  daemon/remote_generator.pl |   17 +  1 files changed, 5 insertions(+),