Re: [libvirt] [PATCH] rpc: RH1026137: Fix slow volume download (virsh vol-download)

2015-08-03 Thread Martin Kletzander
On Mon, Jul 20, 2015 at 05:42:11PM +0300, Ossi Herrala wrote: On Sat, Jun 06, 2015 at 07:36:48PM +, Ossi Herrala wrote: Sorry to miss this mail, it got buried somehow and I haven't got to it until now since nobody pinged it. Sorry for the long wait then. No worries and thank you for taki

Re: [libvirt] [PATCH] rpc: RH1026137: Fix slow volume download (virsh vol-download)

2015-07-20 Thread Ossi Herrala
> On Sat, Jun 06, 2015 at 07:36:48PM +, Ossi Herrala wrote: > > Sorry to miss this mail, it got buried somehow and I haven't got to it > until now since nobody pinged it. Sorry for the long wait then. > No worries and thank you for taking time to review my patch. See new patch attached as w

Re: [libvirt] [PATCH] rpc: RH1026137: Fix slow volume download (virsh vol-download)

2015-07-14 Thread Martin Kletzander
On Sat, Jun 06, 2015 at 07:36:48PM +, Ossi Herrala wrote: Use I/O vector (iovec) instead of one huge memory buffer as suggested in https://bugzilla.redhat.com/show_bug.cgi?id=1026137#c7. This avoids doing memmove() to big buffers and performance doesn't degrade if source (virNetClientStreamQu

[libvirt] [PATCH] rpc: RH1026137: Fix slow volume download (virsh vol-download)

2015-06-06 Thread Ossi Herrala
Use I/O vector (iovec) instead of one huge memory buffer as suggested in https://bugzilla.redhat.com/show_bug.cgi?id=1026137#c7. This avoids doing memmove() to big buffers and performance doesn't degrade if source (virNetClientStreamQueuePacket()) is faster than sink (virNetClientStreamRecvPacket()