Re: [libvirt] [PATCH] secret: Add check/validation for correct usage when LookupByUUID

2018-12-13 Thread Michal Privoznik
On 12/13/18 3:18 PM, John Ferlan wrote: > > > On 12/13/18 8:12 AM, Michal Privoznik wrote: >> On 12/12/18 3:36 PM, John Ferlan wrote: >>> >>> >>> On 12/12/18 9:29 AM, Michal Privoznik wrote: On 12/4/18 9:32 PM, John Ferlan wrote: > If virSecretGetSecretString is using by secretLookupByUU

Re: [libvirt] [PATCH] secret: Add check/validation for correct usage when LookupByUUID

2018-12-13 Thread John Ferlan
On 12/13/18 8:12 AM, Michal Privoznik wrote: > On 12/12/18 3:36 PM, John Ferlan wrote: >> >> >> On 12/12/18 9:29 AM, Michal Privoznik wrote: >>> On 12/4/18 9:32 PM, John Ferlan wrote: If virSecretGetSecretString is using by secretLookupByUUID, then it's possible the found sec->usageTyp

Re: [libvirt] [PATCH] secret: Add check/validation for correct usage when LookupByUUID

2018-12-13 Thread Michal Privoznik
On 12/12/18 3:36 PM, John Ferlan wrote: > > > On 12/12/18 9:29 AM, Michal Privoznik wrote: >> On 12/4/18 9:32 PM, John Ferlan wrote: >>> If virSecretGetSecretString is using by secretLookupByUUID, >>> then it's possible the found sec->usageType doesn't match the >>> desired @secretUsageType. If t

Re: [libvirt] [PATCH] secret: Add check/validation for correct usage when LookupByUUID

2018-12-12 Thread John Ferlan
On 12/12/18 9:29 AM, Michal Privoznik wrote: > On 12/4/18 9:32 PM, John Ferlan wrote: >> If virSecretGetSecretString is using by secretLookupByUUID, >> then it's possible the found sec->usageType doesn't match the >> desired @secretUsageType. If this occurs for the encrypted >> volume creation p

Re: [libvirt] [PATCH] secret: Add check/validation for correct usage when LookupByUUID

2018-12-12 Thread Michal Privoznik
On 12/4/18 9:32 PM, John Ferlan wrote: > If virSecretGetSecretString is using by secretLookupByUUID, > then it's possible the found sec->usageType doesn't match the > desired @secretUsageType. If this occurs for the encrypted > volume creation processing and a subsequent pool refresh is > executed,

Re: [libvirt] [PATCH] secret: Add check/validation for correct usage when LookupByUUID

2018-12-10 Thread John Ferlan
ping? Thanks, John On 12/4/18 3:32 PM, John Ferlan wrote: > If virSecretGetSecretString is using by secretLookupByUUID, > then it's possible the found sec->usageType doesn't match the > desired @secretUsageType. If this occurs for the encrypted > volume creation processing and a subsequent pool

[libvirt] [PATCH] secret: Add check/validation for correct usage when LookupByUUID

2018-12-04 Thread John Ferlan
If virSecretGetSecretString is using by secretLookupByUUID, then it's possible the found sec->usageType doesn't match the desired @secretUsageType. If this occurs for the encrypted volume creation processing and a subsequent pool refresh is executed, then the secret used to create the volume will n