Re: [libvirt] [PATCH] selinux: Don't fail RestoreAll if file doesn't have a default label

2012-10-24 Thread Daniel J Walsh
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/23/2012 10:55 AM, Cole Robinson wrote: On 10/23/2012 06:56 AM, Daniel J Walsh wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/22/2012 04:13 PM, Cole Robinson wrote: On 10/22/2012 11:51 AM, Eric Blake wrote: On 10/21/2012 02:44

Re: [libvirt] [PATCH] selinux: Don't fail RestoreAll if file doesn't have a default label

2012-10-23 Thread Daniel J Walsh
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/22/2012 04:13 PM, Cole Robinson wrote: On 10/22/2012 11:51 AM, Eric Blake wrote: On 10/21/2012 02:44 PM, Cole Robinson wrote: When restoring selinux labels after a VM is stopped, any non-standard path that doesn't have a default selinux

Re: [libvirt] [PATCH] selinux: Don't fail RestoreAll if file doesn't have a default label

2012-10-23 Thread Daniel J Walsh
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/22/2012 04:13 PM, Cole Robinson wrote: On 10/22/2012 11:51 AM, Eric Blake wrote: On 10/21/2012 02:44 PM, Cole Robinson wrote: When restoring selinux labels after a VM is stopped, any non-standard path that doesn't have a default selinux

Re: [libvirt] [PATCH] selinux: Don't fail RestoreAll if file doesn't have a default label

2012-10-23 Thread Cole Robinson
On 10/23/2012 06:56 AM, Daniel J Walsh wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/22/2012 04:13 PM, Cole Robinson wrote: On 10/22/2012 11:51 AM, Eric Blake wrote: On 10/21/2012 02:44 PM, Cole Robinson wrote: When restoring selinux labels after a VM is stopped, any

Re: [libvirt] [PATCH] selinux: Don't fail RestoreAll if file doesn't have a default label

2012-10-23 Thread Cole Robinson
On 10/22/2012 11:51 AM, Eric Blake wrote: On 10/21/2012 02:44 PM, Cole Robinson wrote: When restoring selinux labels after a VM is stopped, any non-standard path that doesn't have a default selinux label causes the process to stop and exit early. This isn't really an error condition IMO. Of

Re: [libvirt] [PATCH] selinux: Don't fail RestoreAll if file doesn't have a default label

2012-10-23 Thread Eric Blake
On 10/23/2012 08:57 AM, Cole Robinson wrote: if (getContext(newpath, buf.st_mode, fcon) 0) { +/* Any user created path likely does not have a default label, + * which makes this an expected non error + */ VIR_WARN(cannot lookup default selinux label for

Re: [libvirt] [PATCH] selinux: Don't fail RestoreAll if file doesn't have a default label

2012-10-23 Thread Cole Robinson
On 10/23/2012 11:42 AM, Eric Blake wrote: On 10/23/2012 08:57 AM, Cole Robinson wrote: if (getContext(newpath, buf.st_mode, fcon) 0) { +/* Any user created path likely does not have a default label, + * which makes this an expected non error + */

Re: [libvirt] [PATCH] selinux: Don't fail RestoreAll if file doesn't have a default label

2012-10-22 Thread Osier Yang
On 2012年10月22日 04:44, Cole Robinson wrote: When restoring selinux labels after a VM is stopped, any non-standard path that doesn't have a default selinux label causes the process to stop and exit early. This isn't really an error condition IMO. Of course the selinux API could be erroring for

Re: [libvirt] [PATCH] selinux: Don't fail RestoreAll if file doesn't have a default label

2012-10-22 Thread Eric Blake
On 10/21/2012 02:44 PM, Cole Robinson wrote: When restoring selinux labels after a VM is stopped, any non-standard path that doesn't have a default selinux label causes the process to stop and exit early. This isn't really an error condition IMO. Of course the selinux API could be erroring

Re: [libvirt] [PATCH] selinux: Don't fail RestoreAll if file doesn't have a default label

2012-10-22 Thread Cole Robinson
On 10/22/2012 11:51 AM, Eric Blake wrote: On 10/21/2012 02:44 PM, Cole Robinson wrote: When restoring selinux labels after a VM is stopped, any non-standard path that doesn't have a default selinux label causes the process to stop and exit early. This isn't really an error condition IMO. Of

[libvirt] [PATCH] selinux: Don't fail RestoreAll if file doesn't have a default label

2012-10-21 Thread Cole Robinson
When restoring selinux labels after a VM is stopped, any non-standard path that doesn't have a default selinux label causes the process to stop and exit early. This isn't really an error condition IMO. Of course the selinux API could be erroring for some other reason but hopefully that's rare