Re: [libvirt] [PATCH] snapshot: fix memory leak on error

2012-04-05 Thread Eric Blake
On 04/05/2012 01:34 PM, Laine Stump wrote: > On 04/05/2012 03:16 PM, Eric Blake wrote: >> Leak introduced in commit 0436d32. If we allocate an actions array, >> but fail early enough to never consume it with the qemu monitor >> transaction call, we leaked memory. >> >> * src/qemu/qemu_driver.c (qe

Re: [libvirt] [PATCH] snapshot: fix memory leak on error

2012-04-05 Thread Laine Stump
On 04/05/2012 03:16 PM, Eric Blake wrote: > Leak introduced in commit 0436d32. If we allocate an actions array, > but fail early enough to never consume it with the qemu monitor > transaction call, we leaked memory. > > * src/qemu/qemu_driver.c (qemuDomainSnapshotCreateDiskActive): > Free actions

[libvirt] [PATCH] snapshot: fix memory leak on error

2012-04-05 Thread Eric Blake
Leak introduced in commit 0436d32. If we allocate an actions array, but fail early enough to never consume it with the qemu monitor transaction call, we leaked memory. * src/qemu/qemu_driver.c (qemuDomainSnapshotCreateDiskActive): Free actions array on failure. --- src/qemu/qemu_driver.c |2